-
Notifications
You must be signed in to change notification settings - Fork 112
Create module for a new Workflow Trace Viewer app #1322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # Workflow Trace Viewer | ||
|
|
||
| A Compose for Desktop app that can be used to view Workflow traces. | ||
|
|
||
| ## Running | ||
|
|
||
| It can be run via Gradle using: | ||
|
|
||
| ```shell | ||
| ./gradlew :workflow-trace-viewer:run | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| public final class com/squareup/workflow1/traceviewer/AppKt { | ||
| public static final fun App (Landroidx/compose/runtime/Composer;I)V | ||
| } | ||
|
|
||
| public final class com/squareup/workflow1/traceviewer/ComposableSingletons$MainKt { | ||
| public static final field INSTANCE Lcom/squareup/workflow1/traceviewer/ComposableSingletons$MainKt; | ||
| public fun <init> ()V | ||
| public final fun getLambda$468449326$wf1_workflow_trace_viewer ()Lkotlin/jvm/functions/Function3; | ||
| } | ||
|
|
||
| public final class com/squareup/workflow1/traceviewer/MainKt { | ||
| public static final fun main ()V | ||
| public static synthetic fun main ([Ljava/lang/String;)V | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| import org.jetbrains.compose.desktop.application.dsl.TargetFormat | ||
|
|
||
| plugins { | ||
| id("kotlin-multiplatform") | ||
| alias(libs.plugins.jetbrains.compose) | ||
| alias(libs.plugins.compose.compiler) | ||
| } | ||
|
|
||
| kotlin { | ||
| jvm() | ||
|
|
||
| sourceSets { | ||
| jvmMain { | ||
| dependencies { | ||
| implementation(compose.runtime) | ||
| implementation(compose.foundation) | ||
| implementation(compose.material) | ||
| implementation(compose.ui) | ||
| implementation(compose.components.resources) | ||
| implementation(compose.components.uiToolingPreview) | ||
| implementation(libs.androidx.lifecycle.viewmodel.core) | ||
| implementation(libs.androidx.lifecycle.compose) | ||
| implementation(compose.desktop.currentOs) | ||
| implementation(libs.kotlinx.coroutines.swing) | ||
| implementation(compose.materialIconsExtended) | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| compose { | ||
| desktop { | ||
| application { | ||
| mainClass = "com.squareup.workflow1.traceviewer.MainKt" | ||
| jvmArgs( | ||
| "-Dapple.awt.application.appearance=system", | ||
| ) | ||
|
|
||
| nativeDistributions { | ||
| includeAllModules = true | ||
| targetFormats(TargetFormat.Dmg) | ||
| packageName = "Workflow Trace Viewer" | ||
| packageVersion = "1.0.0" | ||
| macOS { | ||
| bundleID = "com.squareup.workflow1.traceviewer" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
9 changes: 9 additions & 0 deletions
9
workflow-trace-viewer/src/jvmMain/kotlin/com/squareup/workflow1/traceviewer/App.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| package com.squareup.workflow1.traceviewer | ||
|
|
||
| import androidx.compose.material.Text | ||
| import androidx.compose.runtime.Composable | ||
|
|
||
| @Composable | ||
| fun App() { | ||
| Text("Hello world!") | ||
| } |
9 changes: 9 additions & 0 deletions
9
workflow-trace-viewer/src/jvmMain/kotlin/com/squareup/workflow1/traceviewer/Main.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| package com.squareup.workflow1.traceviewer | ||
|
|
||
| import androidx.compose.ui.window.singleWindowApplication | ||
|
|
||
| fun main() { | ||
| singleWindowApplication(title = "Workflow Trace Viewer") { | ||
| App() | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a lot of these are forward looking what might be useful, right? But will these
androidxones be usable?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, they're KMP now and are expected to used with Compose for Desktop.