Create module for a new Workflow Trace Viewer app #1322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
wardellbagby
commented
May 22, 2025
wardellbagby
commented
- Creates a new module that when ran, runs a Compose for Desktop app. The plan is for that module to host a new desktop app for viewing Workflow traces.
|
|
|
Bah, I broke Kotlin. Gimmie a bit here. |
wardellbagby
force-pushed
the
wardell/create-trace-viewer-scaffold
branch
from
e983d14 to
6f8c318
Compare
wardellbagby
changed the base branch from
main
to
sedwards/update-actions-for-central
steve-the-edwards
changed the base branch from
sedwards/update-actions-for-central
to
sedwards/no-strict-trace
steve-the-edwards
force-pushed
the
wardell/create-trace-viewer-scaffold
branch
from
6f8c318 to
1c9337e
Compare
- Creates a new module that when ran, runs a Compose for Desktop app. The plan is for that module to host a new desktop app for viewing Workflow traces.
steve-the-edwards
force-pushed
the
wardell/create-trace-viewer-scaffold
branch
from
1c9337e to
4529948
Compare
steve-the-edwards
approved these changes
May 23, 2025
Comment on lines
+21
to
+22
| implementation(libs.androidx.lifecycle.viewmodel.core) | ||
| implementation(libs.androidx.lifecycle.compose) |
There was a problem hiding this comment.
I think a lot of these are forward looking what might be useful, right? But will these androidx ones be usable?
There was a problem hiding this comment.
Yeah, they're KMP now and are expected to used with Compose for Desktop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.