[Intermediate Representation] Generate AnalyzeIR #997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiguoz
force-pushed
the
analyzer_ir_generator
branch
2 times, most recently
from
f91555e to
516073f
Compare
weiguoz
force-pushed
the
analyzer_ir_generator
branch
from
675fc40 to
d635bf2
Compare
weiguoz
requested review from
shendiaomo,
tonyyang-svail,
typhoonzero and
wangkuiyi
weiguoz
changed the title
| // TODO(joyyoj) read feature mapping table's name from table attributes. | ||
| // TODO(joyyoj) pr may contains partition. | ||
| fmap := columns.FeatureMap{pr.tables[0] + "_feature_map", ""} | ||
| fmap := columns.FeatureMap{ |
Collaborator
There was a problem hiding this comment.
Not sure why we need to change these files. Have you used a code formatter?
| userSpec.DType, | ||
| userSpec.Delimiter, | ||
| nil, | ||
| *meta.featureMap} |
Collaborator
There was a problem hiding this comment.
Is there a linter complaining we need to explicitly name the field name? If so, please file the change in a separate PR.
Collaborator
Author
There was a problem hiding this comment.
The go vet complains: [govet] xxx(struct) composite literal uses unkeyed fields [E] while I'm editing in another file.
I found that there was not much code to be changed, so I changed them conveniently.
shendiaomo
pushed a commit
to shendiaomo/sqlflow
that referenced
this pull request
Oct 22, 2019
…g#997) * Remove complaints: "GOLANG: composite literal uses unkeyed fields" * add explainer for AnalyzeIR * add test for analyzeIR * add ut for generateAnalyzeIR * remove TO before TRAIN/ANALYZE in ut
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #976