-
Notifications
You must be signed in to change notification settings - Fork 705
[Intermediate Representation] Generate AnalyzeIR #997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
0c7388e
27d23c3
1f8dad7
3e8324c
d635bf2
b6c9897
00733b8
39760b4
7d9e5ce
9e35148
7225c3b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -188,7 +188,9 @@ func newALPSTrainFiller(pr *extendedSelect, db *DB, session *pb.Session, ds *tra | |
|
|
||
| // TODO(joyyoj) read feature mapping table's name from table attributes. | ||
| // TODO(joyyoj) pr may contains partition. | ||
| fmap := columns.FeatureMap{pr.tables[0] + "_feature_map", ""} | ||
| fmap := columns.FeatureMap{ | ||
| Table: pr.tables[0] + "_feature_map", | ||
| Partition: ""} | ||
| var meta metadata | ||
| fields := make([]string, 0) | ||
| if db != nil { | ||
|
|
@@ -670,22 +672,22 @@ func (meta *metadata) getDenseColumnInfo(keys []string, refColumns map[string]*c | |
| shape[0] = len(fields) | ||
| if userSpec, ok := refColumns[ct.Name()]; ok { | ||
| output[ct.Name()] = &columns.ColumnSpec{ | ||
| ct.Name(), | ||
| false, | ||
| shape, | ||
| userSpec.DType, | ||
| userSpec.Delimiter, | ||
| nil, | ||
| *meta.featureMap} | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a linter complaining we need to explicitly name the field name? If so, please file the change in a separate PR.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The go vet complains: |
||
| ColumnName: ct.Name(), | ||
| IsSparse: false, | ||
| Shape: shape, | ||
| DType: userSpec.DType, | ||
| Delimiter: userSpec.Delimiter, | ||
| Vocabulary: nil, | ||
| FeatureMap: *meta.featureMap} | ||
| } else { | ||
| output[ct.Name()] = &columns.ColumnSpec{ | ||
| ct.Name(), | ||
| false, | ||
| shape, | ||
| "float", | ||
| ",", | ||
| nil, | ||
| *meta.featureMap} | ||
| ColumnName: ct.Name(), | ||
| IsSparse: false, | ||
| Shape: shape, | ||
| DType: "float", | ||
| Delimiter: ",", | ||
| Vocabulary: nil, | ||
| FeatureMap: *meta.featureMap} | ||
| } | ||
| } | ||
| } | ||
|
|
@@ -732,7 +734,14 @@ func (meta *metadata) getSparseColumnInfo() (map[string]*columns.ColumnSpec, err | |
| column, present := output[*name] | ||
| if !present { | ||
| shape := make([]int, 0, 1000) | ||
| column := &columns.ColumnSpec{*name, true, shape, "int64", "", nil, *meta.featureMap} | ||
| column := &columns.ColumnSpec{ | ||
| ColumnName: *name, | ||
| IsSparse: true, | ||
| Shape: shape, | ||
| DType: "int64", | ||
| Delimiter: "", | ||
| Vocabulary: nil, | ||
| FeatureMap: *meta.featureMap} | ||
| column.DType = "int64" | ||
| output[*name] = column | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why we need to change these files. Have you used a code formatter?