Skip to content

Correctly retrieve operation name from the body of the request #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Correctly retrieve operation name from the body of the request #742

wants to merge 1 commit into from

Conversation

koenpunt
Copy link
Contributor

@koenpunt koenpunt commented Jun 27, 2023 •
edited
Loading

In 1406ca2 the body key was changed from operationName to operation, which I think was an error, because now for example setting the operation name on the WebGraphQlTester doesn't work anymore.

I've look into adding a test for the faulty behavior, but not sure where to add that.

@koenpunt koenpunt force-pushed the fix-operation-name branch from 1ae68e5 to 046cef6 Compare June 27, 2023 13:13
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 27, 2023
@bclozel bclozel mentioned this pull request Jun 27, 2023
Closed
@bclozel bclozel added type: bug A general bug in: web Issues related to web handling and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 27, 2023
@rstoyanchev rstoyanchev added this to the 1.2.2 milestone Jun 28, 2023
@rstoyanchev rstoyanchev added type: regression A bug that is also a regression and removed type: bug A general bug labels Jun 28, 2023
@rstoyanchev rstoyanchev changed the title Fix: correctly retrieve operation from request body Correctly retrieve operation name from the body of the request Jun 28, 2023
@rstoyanchev rstoyanchev mentioned this pull request Jun 28, 2023
Closed
rstoyanchev pushed a commit that referenced this pull request Jul 3, 2023
@koenpunt @rstoyanchev
Correctly retrieve operation from request body
e742404 
See gh-742
@koenpunt koenpunt mentioned this pull request Jul 20, 2023
Closed
@koenpunt
Copy link
Contributor Author

@rstoyanchev this should be backported to 1.0.x as well, because 1.0.5 now introduced this same bug.

@koenpunt
Copy link
Contributor Author

Oh and also 1.1.x apparently; https://github.com/spring-projects/spring-graphql/blob/1.1.x/spring-graphql/src/main/java/org/springframework/graphql/server/WebGraphQlRequest.java#L108

This was referenced Sep 19, 2023
Closed
Closed
@rstoyanchev rstoyanchev added the status: backported An issue that has been backported to maintenance branches label Sep 19, 2023
@rstoyanchev
Copy link
Contributor

rstoyanchev commented Sep 19, 2023 •
edited
Loading

Yes, you're right. We'll backport with #818 and #819, and release immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues related to web handling status: backported An issue that has been backported to maintenance branches type: regression A bug that is also a regression
Projects
None yet
Milestone
1.2.2
Development

Successfully merging this pull request may close these issues.
4 participants
@koenpunt @rstoyanchev @bclozel @spring-projects-issues