Local context is overwritten by Observation instrumentation

[koenpunt]

We haven't been able to update to a newer version than 1.1.3 because unfortunately every time new bugs are introduced.

The last thing that was broken was #742, now that's fixed and out with the 3.1.2 boot-starter. However, now apparently using local context no longer works.

We have the following in multiple places in our application:

DataFetcherResult.newResult<T>()
        .data(data)
        .localContext(GraphQLContext.of(contextMap))
        .build()

But now all that is found in the local context in child resolver functions is the micrometer.observation key.

I understand it's not intentional, but it is quite annoying that fixes are released with other changes that cause new issues.

[koenpunt]

After some more testing I see this actually broke between 1.1.3 and 1.1.4

[koenpunt]

I think the problem lies here, where a new result is created without copying the localContext from the environment:

spring-graphql/spring-graphql/src/main/java/org/springframework/graphql/observation/GraphQlObservationInstrumentation.java

Lines 204 to 207 in 0ca470d

	return DataFetcherResult.newResult()
	.data(value)
	.localContext(GraphQLContext.newContext().of(ObservationThreadLocalAccessor.KEY, dataFetcherObservation).build())
	.build();

[bclozel]

Closing in favor of #761

[bclozel]

@koenpunt we have fixed quite a few important issues lately. Can you check that the current SNAPSHOTs are working well with your applications? We are going to release maintenance versions for 1.1.x and 1.2.x in a few days.
Thanks!

[koenpunt]

We're currently running the 1.2.3 snapshot which works for us 👍

[ABINTC]

@bclozel I still see this issue in 1.2.4 ! 😔

[bclozel]

@ABINTC please create a new issue with a minimal, sample application reproducing the problem and I'll have a look. Thanks!