Skip to content

Conversation

hengyunabc
Copy link
Contributor

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 26, 2020
@wilkinsona
Copy link
Member

Thanks for the PR. The version's really intended to be a hypothetical placeholder rather than an actual version. The 2.2 docs have versions like this:

<version>@maven-jar-plugin.version@</version>

I wonder if we'd be better using something like that in 2.3 and later (where the docs are now Asciidoctor), rather than specifying a genuine version which we'd then probably want to try to keep up-to-date. Either way, I think it'd be nice to handle this consistently across all the currently maintained branches.

What would you find most useful, @hengyunabc? I'll also flag this for team attention to see what the rest of the team thinks.

@wilkinsona wilkinsona added the for: team-attention An issue we'd like other members of the team to review label Oct 26, 2020
@philwebb
Copy link
Member

Thanks for the pull-request. We've decided it's better for us to remove the <version> elements entirely. We'll do that in #23909

@philwebb philwebb closed this Oct 26, 2020
@philwebb philwebb added status: declined A suggestion or change that we don't feel we should currently apply and removed for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants