Exclude AWS Redshift from DatabaseDriverClassNameTests #16905
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 146f35d introduced support for the AWS Redshift driver, but missed to exclude it in DatabaseDriverClassNameTests and caused failing builds.
|
Thank you @dreis2211 and @wilkinsona for catching up my faulty review! |
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: task
|
Thank you, @dreis2211, but I'd already fixed this locally before I saw your PR. See f8eb230. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
apparently 146f35d broke the current master as the new driver is not excluded from DatabaseDriverClassNameTests. For simplicity reasons, I simply excluded it for now.
Cheers,
Christoph