Skip to content

Add support for AWS Redshift JDBC driver #16831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add support for AWS Redshift JDBC driver #16831

wants to merge 2 commits into from

Conversation

hekonsek
Copy link
Contributor

Hi,

Nothing fancy here - just added AWS Redshift JDBC driver definition to DatabaseDriver enum, so it could be auto-detected by DataSourceBuilder.

Thanks!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 13, 2019
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels May 14, 2019
@philwebb philwebb added this to the 2.2.x milestone May 14, 2019
@philwebb
Copy link
Member

Nice, thanks!

@snicoll snicoll changed the title Added AWS Redshift driver to DatabaseDriver enum Add support for AWS Redshift JDBC driver May 20, 2019
@snicoll snicoll self-assigned this May 20, 2019
@snicoll snicoll modified the milestones: 2.2.x, 2.2.0.M4 May 20, 2019
snicoll pushed a commit that referenced this pull request May 20, 2019
@hekonsek @snicoll
Add support for AWS Redshift JDBC driver
146f35d 
See gh-16831
@snicoll snicoll closed this in 9e31c76 May 20, 2019
snicoll added a commit that referenced this pull request May 20, 2019
@snicoll
Merge pull request #16831 from hekonsek
4f4fe01 
* pr/16831:
  Polish "Add support for AWS Redshift JDBC driver"
  Add support for AWS Redshift JDBC driver
@snicoll
Copy link
Member

snicoll commented May 20, 2019

Thanks @hekonsek!

@hekonsek
Copy link
Contributor Author

Thank you for merging!

@wilkinsona
Copy link
Member

Re-opening as the change has broken the build. It causes DatabaseDriverClassNameTests to fail as com.amazon.redshift.jdbc.Driver isn't on the classpath. Redshift needs to be excluded from the tests.

@wilkinsona wilkinsona reopened this May 20, 2019
@dreis2211
Copy link
Contributor

dreis2211 commented May 20, 2019 •
edited
Loading

I was already working on exactly this fix, while you reopened this @wilkinsona . See gh-16905.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@snicoll snicoll

Labels

type: enhancement A general enhancement

Projects

None yet

Milestone

2.2.0.M4

Development

Successfully merging this pull request may close these issues.

6 participants

@hekonsek @philwebb @snicoll @wilkinsona @dreis2211 @spring-projects-issues