Skip to content

Add the enableSpringELCompiler on ThymeleafProperties #10869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add the enableSpringELCompiler on ThymeleafProperties #10869

wants to merge 1 commit into from

Conversation

@kazuki43zoo
Copy link
Contributor

@kazuki43zoo kazuki43zoo commented Nov 1, 2017 •
edited
Loading

I suggest adding the enableSpringElCompiler property on the ThymeleafProperties.
By this change, we can be changed the SpringTemplateEngine#enableSpringELCompiler to true more easier.

WDYT?

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 1, 2017
@philwebb
Copy link
Member

philwebb commented Nov 1, 2017

LGTM but lets see what the rest of the team think.

@philwebb philwebb added the for: team-attention An issue we'd like other members of the team to review label Nov 1, 2017
@kazuki43zoo kazuki43zoo force-pushed the support-EnableSpringELCompiler-on-thymeleaf branch from a9ce5ee to e433e28 Compare November 1, 2017 22:49
@kazuki43zoo
Copy link
Contributor Author

kazuki43zoo commented Nov 1, 2017 •
edited
Loading

I've updated.

  • fix checkstyle error
  • fix property name (enableSpringELCompiler -> enableSpringElCompiler )
  • update document

@kazuki43zoo kazuki43zoo force-pushed the support-EnableSpringELCompiler-on-thymeleaf branch from e433e28 to a6a041a Compare November 2, 2017 12:57
@kazuki43zoo
Copy link
Contributor Author

kazuki43zoo commented Nov 2, 2017

I've updated.

  • fix setter argument variable name (enableSpringELCompiler -> enableSpringElCompiler )

@kazuki43zoo kazuki43zoo force-pushed the support-EnableSpringELCompiler-on-thymeleaf branch from a6a041a to acb71c1 Compare November 2, 2017 13:12
@philwebb philwebb added for: merge-with-amendments Needs some changes when we merge type: enhancement A general enhancement and removed for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels Nov 15, 2017
@philwebb philwebb added this to the 2.0.0.M7 milestone Nov 15, 2017
@snicoll snicoll self-assigned this Nov 16, 2017
@snicoll snicoll removed the for: merge-with-amendments Needs some changes when we merge label Nov 16, 2017
snicoll pushed a commit that referenced this pull request Nov 16, 2017
@kazuki43zoo @snicoll
Add 'enableSpringElCompiler' to ThymeleafProperties
cf350cf 
See gh-10869
@snicoll snicoll closed this in a0374c0 Nov 16, 2017
snicoll added a commit that referenced this pull request Nov 16, 2017
@snicoll
Merge pull request #10869 from kazuki43zoo:support-EnableSpringELComp…
e34c2b0 
…iler-on-thymeleaf

* pr/10869:
  Polish "Add 'enableSpringElCompiler' to ThymeleafProperties"
  Add 'enableSpringElCompiler' to ThymeleafProperties
@kazuki43zoo kazuki43zoo deleted the support-EnableSpringELCompiler-on-thymeleaf branch November 18, 2017 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@snicoll snicoll

Labels

type: enhancement A general enhancement

Projects

None yet

Milestone

2.0.0.M7

Development

Successfully merging this pull request may close these issues.

4 participants

@kazuki43zoo @philwebb @snicoll @spring-projects-issues