Skip to content

Commit a0374c0

Browse files
committed
Polish "Add 'enableSpringElCompiler' to ThymeleafProperties"
Closes gh-10869
1 parent cf350cf commit a0374c0

File tree

3 files changed

+29
-25
lines changed

3 files changed

+29
-25
lines changed

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/thymeleaf/ThymeleafAutoConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,9 +150,9 @@ public ThymeleafDefaultConfiguration(ThymeleafProperties properties,
150150
@ConditionalOnMissingBean(SpringTemplateEngine.class)
151151
public SpringTemplateEngine templateEngine() {
152152
SpringTemplateEngine engine = new SpringTemplateEngine();
153+
engine.setEnableSpringELCompiler(this.properties.isEnableSpringElCompiler());
153154
this.templateResolvers.forEach(engine::addTemplateResolver);
154155
this.dialects.forEach(engine::addDialect);
155-
engine.setEnableSpringELCompiler(this.properties.isEnableSpringElCompiler());
156156
return engine;
157157
}
158158

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/thymeleaf/ThymeleafReactiveAutoConfigurationTests.java

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,20 @@ public void overrideChunkedModeViewNames() throws Exception {
141141
.isEqualTo(new String[] { "foo", "bar" });
142142
}
143143

144+
@Test
145+
public void overrideEnableSpringElCompiler() {
146+
load(BaseConfiguration.class, "spring.thymeleaf.enable-spring-el-compiler:true");
147+
assertThat(this.context.getBean(SpringWebFluxTemplateEngine.class)
148+
.getEnableSpringELCompiler()).isTrue();
149+
}
150+
151+
@Test
152+
public void enableSpringElCompilerIsDisabledByDefault() {
153+
load(BaseConfiguration.class);
154+
assertThat(this.context.getBean(SpringWebFluxTemplateEngine.class)
155+
.getEnableSpringELCompiler()).isFalse();
156+
}
157+
144158
@Test
145159
public void templateLocationDoesNotExist() throws Exception {
146160
load(BaseConfiguration.class,
@@ -194,18 +208,6 @@ public void layoutDialectCanBeCustomized() throws Exception {
194208
.isInstanceOf(GroupingStrategy.class);
195209
}
196210

197-
@Test
198-
public void enableSpringElCompilerCanBeEnabled() {
199-
load(BaseConfiguration.class, "spring.thymeleaf.enable-spring-el-compiler:true");
200-
assertThat(this.context.getBean(SpringWebFluxTemplateEngine.class).getEnableSpringELCompiler()).isTrue();
201-
}
202-
203-
@Test
204-
public void enableSpringElCompilerIsDisabledByDefault() {
205-
load(BaseConfiguration.class);
206-
assertThat(this.context.getBean(SpringWebFluxTemplateEngine.class).getEnableSpringELCompiler()).isFalse();
207-
}
208-
209211
private void load(Class<?> config, String... envVariables) {
210212
this.context = new AnnotationConfigReactiveWebApplicationContext();
211213
TestPropertyValues.of(envVariables).applyTo(this.context);

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/thymeleaf/ThymeleafServletAutoConfigurationTests.java

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,20 @@ public void overrideViewNames() throws Exception {
112112
assertThat(views.getViewNames()).isEqualTo(new String[] { "foo", "bar" });
113113
}
114114

115+
@Test
116+
public void overrideEnableSpringElCompiler() {
117+
load(BaseConfiguration.class, "spring.thymeleaf.enable-spring-el-compiler:true");
118+
assertThat(this.context.getBean(SpringTemplateEngine.class)
119+
.getEnableSpringELCompiler()).isTrue();
120+
}
121+
122+
@Test
123+
public void enableSpringElCompilerIsDisabledByDefault() {
124+
load(BaseConfiguration.class);
125+
assertThat(this.context.getBean(SpringTemplateEngine.class)
126+
.getEnableSpringELCompiler()).isFalse();
127+
}
128+
115129
@Test
116130
public void templateLocationDoesNotExist() throws Exception {
117131
load(BaseConfiguration.class,
@@ -219,18 +233,6 @@ public void cachingCanBeDisabled() {
219233
assertThat(templateResolver.isCacheable()).isFalse();
220234
}
221235

222-
@Test
223-
public void enableSpringElCompilerCanBeEnabled() {
224-
load(BaseConfiguration.class, "spring.thymeleaf.enable-spring-el-compiler:true");
225-
assertThat(this.context.getBean(SpringTemplateEngine.class).getEnableSpringELCompiler()).isTrue();
226-
}
227-
228-
@Test
229-
public void enableSpringElCompilerIsDisabledByDefault() {
230-
load(BaseConfiguration.class);
231-
assertThat(this.context.getBean(SpringTemplateEngine.class).getEnableSpringELCompiler()).isFalse();
232-
}
233-
234236
private void load(Class<?> config, String... envVariables) {
235237
this.context = new AnnotationConfigWebApplicationContext();
236238
TestPropertyValues.of(envVariables).applyTo(this.context);

0 commit comments

Comments
 (0)