Make check-location property consistent in Flyway and Liquibase #10807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
I'm thinking twice about renaming the properties. While things are now consistent between Flyway and Liquibase, the Liquibase properties for configuring the change log and checking it don't match up any more. |
wilkinsona
added
the
for: team-attention
|
I'm tempted to keep the two properties distinct as well. I think the consistency within the class is more important that consistency between Flyway & Liquibase. |
|
@eddumelendez Sorry for changing our minds on this one. Would you like to update your pull request so that it just switches the default value and leaves the property names unchanged? |
wilkinsona
added
status: waiting-for-feedback
eddumelendez
force-pushed
the
gh-10464
branch
from
1c38c23 to
2711f5a
Compare
philwebb
added
priority: normal
type: enhancement
wilkinsona
added a commit
that referenced
this pull request
Nov 2, 2017
* gh-10807: Align default of flyway.check-location with equivalent Liquibase prop
|
Thank you once again, @eddumelendez |
wilkinsona
added a commit
that referenced
this pull request
Nov 2, 2017
Flyway implicitly adds classpath: to locations without a prefix but resource loader fails to find migratons on the classpath without the prefix. Add an explicit classpath: prefix so that both Flyway and the resource loader used to check the locations can find the migration location. See gh-10807
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See gh-10464