Make check-location property consistent in Flyway and Liquibase

See gh-10464

Author: eddumelendez

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/flyway/FlywayProperties.java

@@ -31,6 +31,7 @@
  * properties into the {@link Flyway} instance.
  *
  * @author Dave Syer
+ * @author Eddú Meléndez
  * @since 1.1.0
  */
 @ConfigurationProperties(prefix = "spring.flyway", ignoreUnknownFields = true)
@@ -46,7 +47,7 @@ public class FlywayProperties {
 	/**
 	 * Check that migration scripts location exists.
 	 */
-	private boolean checkLocation = false;
+	private boolean checkLocation = true;
 
 	/**
 	 * Enable flyway.

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/liquibase/LiquibaseAutoConfiguration.java

@@ -99,7 +99,7 @@ public LiquibaseConfiguration(LiquibaseProperties properties,
 
 		@PostConstruct
 		public void checkChangelogExists() {
-			if (this.properties.isCheckChangeLogLocation()) {
+			if (this.properties.isCheckLocation()) {
 				Resource resource = this.resourceLoader
 						.getResource(this.properties.getChangeLog());
 				Assert.state(resource.exists(),

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/liquibase/LiquibaseProperties.java

@@ -28,6 +28,7 @@
  * Configuration properties to configure {@link SpringLiquibase}.
  *
  * @author Marcel Overdijk
+ * @author Eddú Meléndez
  * @since 1.1.0
  */
 @ConfigurationProperties(prefix = "spring.liquibase", ignoreUnknownFields = false)
@@ -41,7 +42,7 @@ public class LiquibaseProperties {
 	/**
 	 * Check the change log location exists.
 	 */
-	private boolean checkChangeLogLocation = true;
+	private boolean checkLocation = true;
 
 	/**
 	 * Comma-separated list of runtime contexts to use.
@@ -103,12 +104,12 @@ public void setChangeLog(String changeLog) {
 		this.changeLog = changeLog;
 	}
 
-	public boolean isCheckChangeLogLocation() {
-		return this.checkChangeLogLocation;
+	public boolean isCheckLocation() {
+		return this.checkLocation;
 	}
 
-	public void setCheckChangeLogLocation(boolean checkChangeLogLocation) {
-		this.checkChangeLogLocation = checkChangeLogLocation;
+	public void setCheckLocation(boolean checkLocation) {
+		this.checkLocation = checkLocation;
 	}
 
 	public String getContexts() {

spring-boot-project/spring-boot-autoconfigure/src/main/resources/META-INF/additional-spring-configuration-metadata.json

@@ -686,7 +686,7 @@
     "description": "Check the change log location exists.",
     "defaultValue": true,
     "deprecation": {
-      "replacement": "spring.liquibase.check-change-log-location",
+      "replacement": "spring.liquibase.check-location",
       "level": "error"
     }
   },

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/flyway/FlywayAutoConfigurationTests.java

@@ -173,8 +173,7 @@ public void changeLogDoesNotExist() {
 	public void checkLocationsAllMissing() {
 		this.contextRunner.withUserConfiguration(EmbeddedDataSourceConfiguration.class)
 				.withPropertyValues(
-						"spring.flyway.locations:classpath:db/missing1,classpath:db/migration2",
-						"spring.flyway.check-location:true")
+						"spring.flyway.locations:classpath:db/missing1,classpath:db/migration2")
 				.run((context) -> {
 					assertThat(context).hasFailed();
 					assertThat(context).getFailure()
@@ -188,8 +187,7 @@ public void checkLocationsAllMissing() {
 	public void checkLocationsAllExist() {
 		this.contextRunner.withUserConfiguration(EmbeddedDataSourceConfiguration.class)
 				.withPropertyValues(
-						"spring.flyway.locations:classpath:db/changelog,classpath:db/migration",
-						"spring.flyway.check-location:true")
+						"spring.flyway.locations:classpath:db/changelog,classpath:db/migration")
 				.run((context) -> assertThat(context).hasNotFailed());
 	}
 

spring-boot-project/spring-boot-docs/src/main/asciidoc/appendix-application-properties.adoc

@@ -497,7 +497,7 @@ content into your application; rather pick only the properties that you need.
 	spring.flyway.baseline-description= #
 	spring.flyway.baseline-on-migrate= #
 	spring.flyway.baseline-version=1 # version to start migration
-	spring.flyway.check-location=false # Check that migration scripts location exists.
+	spring.flyway.check-location=true # Check that migration scripts location exists.
 	spring.flyway.clean-disabled= #
 	spring.flyway.clean-on-validation-error= #
 	spring.flyway.enabled=true # Enable flyway.
@@ -531,7 +531,7 @@ content into your application; rather pick only the properties that you need.
 
 	# LIQUIBASE ({sc-spring-boot-autoconfigure}/liquibase/LiquibaseProperties.{sc-ext}[LiquibaseProperties])
 	spring.liquibase.change-log=classpath:/db/changelog/db.changelog-master.yaml # Change log configuration path.
-	spring.liquibase.check-change-log-location=true # Check the change log location exists.
+	spring.liquibase.check-location=true # Check the change log location exists.
 	spring.liquibase.contexts= # Comma-separated list of runtime contexts to use.
 	spring.liquibase.default-schema= # Default database schema.
 	spring.liquibase.drop-first=false # Drop the database schema first.