Skip to content

Fix wrong Javadoc #4745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix wrong Javadoc #4745

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...s/spring-ai-zhipuai/src/main/java/org/springframework/ai/zhipuai/api/ZhiPuAiImageApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public class ZhiPuAiImageApi {

/**
* Create a new ZhiPuAI Image api with base URL set to
* {@code https://api.ZhiPuAI.com}.
* {@code https://open.bigmodel.cn/api/paas}.
Copy link
Contributor

@sobychacko sobychacko Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we can't access either of these two URL's. how about removing it altogether?

Copy link
Contributor Author

@quaff quaff Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the value of ZhiPuApiConstants.DEFAULT_BASE_URL.

Copy link
Member

@ilayaperumalg ilayaperumalg Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the current URL is no longer valid, shouldn't the default constant value be changed as well then?

Copy link
Contributor Author

@quaff quaff Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's accessible from my country.

Copy link
Member

@ilayaperumalg ilayaperumalg Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's accessible from my country.

I understand that. What I meant is, if the URL "https://api.ZhiPuAI.com" is no longer valid, then shouldn't the URL "https://open.bigmodel.cn/api/paas" be set as the default as well?

Copy link
Contributor Author

@quaff quaff Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess https://api.zhipuai.com/ is wrong at the beginning.

Copy link
Member

@ilayaperumalg ilayaperumalg Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quaff I misunderstood the changes. I overlooked the ZhiPuApiConstants.DEFAULT_BASE_URL value as I thought it had "https://api.ZhiPuAI.com" at the first place. Sorry about that. Merging.

* @param zhiPuAiToken ZhiPuAI apiKey.
*/
public ZhiPuAiImageApi(String zhiPuAiToken) {
Expand Down