Fix wrong Javadoc #4745
Fix wrong Javadoc #4745
Conversation
Signed-off-by: Yanming Zhou <[email protected]>
| /** | ||
| * Create a new ZhiPuAI Image api with base URL set to | ||
| * {@code https://api.ZhiPuAI.com}. | ||
| * {@code https://open.bigmodel.cn/api/paas}. |
There was a problem hiding this comment.
It looks like we can't access either of these two URL's. how about removing it altogether?
There was a problem hiding this comment.
It's the value of ZhiPuApiConstants.DEFAULT_BASE_URL.
There was a problem hiding this comment.
If the current URL is no longer valid, shouldn't the default constant value be changed as well then?
There was a problem hiding this comment.
It's accessible from my country.
There was a problem hiding this comment.
It's accessible from my country.
I understand that. What I meant is, if the URL "https://api.ZhiPuAI.com" is no longer valid, then shouldn't the URL "https://open.bigmodel.cn/api/paas" be set as the default as well?
There was a problem hiding this comment.
I guess https://api.zhipuai.com/ is wrong at the beginning.
There was a problem hiding this comment.
@quaff I misunderstood the changes. I overlooked the ZhiPuApiConstants.DEFAULT_BASE_URL value as I thought it had "https://api.ZhiPuAI.com" at the first place. Sorry about that. Merging.
|
Rebased and merged as cb6afde |
3 participants
No description provided.