Skip to content

Conversation

@alxkm
Copy link
Contributor

@alxkm alxkm commented Aug 6, 2025

Adds new test cases to strengthen SpringAiCoreRuntimeHintsTest:

  • Null ClassLoader handling - Ensures registration doesn't fail when ClassLoader parameter is null
  • Embedding resource validation - Confirms embedding-model-dimensions.properties is registered
  • Tool reflection hints - Validates ToolCallback and ToolDefinition classes have proper reflection hints
  • Separate hint validation - Tests resource and reflection hints independently
  • Idempotent registration - Ensures consistent hint registration across multiple calls
  • Path precision testing - Validates exact resource paths and prevents incorrect matches
  • Comprehensive validation - Confirms both resource and reflection hints are present

These tests ensure proper registration of embedding model dimensions and tool system hints, preventing native image runtime failures when accessing embedding properties or using AI function calling.

@sobychacko
Copy link
Contributor

Thanks for the PR. Just making sure that you saw this comment: #4013 (comment). This way, it is easier for review/merge (if you are planning to send multiple of these PR's addressing single tests). Thanks!

@alxkm
Copy link
Contributor Author

alxkm commented Aug 6, 2025

@sobychacko Thanks! I get it now. I thought splitting PRs by functionality would help, but now I understand your point. I’ll try to group them better by related areas in the future.

@sobychacko sobychacko added this to the 1.1.0.M1 milestone Aug 6, 2025
@sobychacko sobychacko merged commit 7d6f9be into spring-projects:main Aug 6, 2025
2 checks passed
juntae6942 pushed a commit to juntae6942/spring-ai that referenced this pull request Aug 7, 2025
scionaltera pushed a commit to scionaltera/spring-ai that referenced this pull request Sep 3, 2025
chedim pushed a commit to couchbaselabs/spring-ai that referenced this pull request Sep 19, 2025
Willam2004 pushed a commit to Willam2004/spring-ai that referenced this pull request Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants