Skip to content

Conversation

@alxkm
Copy link
Contributor

@alxkm alxkm commented Aug 6, 2025

Adds new test cases to strengthen VertexAiGeminiRuntimeHintsTests:

  • Null ClassLoader handling - Ensures hint registration works with null ClassLoader (common in AOT)
  • Basic reflection hints validation - Verifies hints are actually registered
  • Idempotent registration - Prevents duplicate hint registration on multiple calls
  • Package validation - Confirms JSON annotated classes are found from correct package
  • Hint count validation - Prevents excessive hint bloat that impacts native image build time

These tests catch potential AOT/GraalVM native compilation issues that could cause runtime failures.

@sobychacko sobychacko added this to the 1.1.0.M1 milestone Aug 6, 2025
@sobychacko
Copy link
Contributor

@alxkm Thanks for all these PR's. One minor suggestion - if you are planning to add more PR's increasing the test coverage, try to batch a few tests in a single PR (and mention those in the commit message) instead of sending individual PR's per test. It will be easier for us to review/merge. Thanks!

@sobychacko sobychacko merged commit c5a9568 into spring-projects:main Aug 6, 2025
2 checks passed
scionaltera pushed a commit to scionaltera/spring-ai that referenced this pull request Sep 3, 2025
chedim pushed a commit to couchbaselabs/spring-ai that referenced this pull request Sep 19, 2025
Willam2004 pushed a commit to Willam2004/spring-ai that referenced this pull request Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants