Skip to content

Conversation

@Gitesh307
Copy link
Contributor

@Gitesh307 Gitesh307 commented Oct 1, 2025

Fixes #7440

This PR introduces a new feature Collection Preferences page that consolidates collection-level settings such as picklists, attachments, tree management, statistics, Specify Network integration, and catalog number inheritance. Updated localization handling to use explicit function calls, resolving scanner issues. No database changes; existing preferences migrate automatically at the collection level.

image image image

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

  • Verify the new Collection Preferences menu is visible only to authorized roles, settings can be saved and persist per collection.
  • Modify values in each section, ensure they save and persist after reload, and verify that the Reset button restores defaults correctly.
  • Test each option and verify application behavior responds to the setting

@Gitesh307 Gitesh307 changed the title Fix:Expose general collection prefs for picklist scoping and attachme… Feat(preferences): Add “Collection Preferences” page with role-gated access Oct 3, 2025
@Gitesh307 Gitesh307 requested review from a team and removed request for a team October 6, 2025 15:14
@CarolineDenis CarolineDenis removed the request for review from a team October 6, 2025 16:33
Triggered by a0e5463 on branch refs/heads/issue-7440
Copy link
Member

@grantfitzsimmons grantfitzsimmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a decent number of new changes, can you please review @Gitesh307?

  • Now Collection Preferences looks and works much more like User Preferences, with an added sidebar
  • Preference descriptions are now much more detailed and inline with the requirements
  • Descriptions and options use localized captions for table and field names, for both trees and CO inheritance
  • Added a new icon for collection preferences in particular

This PR is still missing "Collection Object Creation", but not needed if we are implementing #7439?

@Gitesh307
Copy link
Contributor Author

There are a decent number of new changes, can you please review @Gitesh307?

  • Now Collection Preferences looks and works much more like User Preferences, with an added sidebar
  • Preference descriptions are now much more detailed and inline with the requirements
  • Descriptions and options use localized captions for table and field names, for both trees and CO inheritance
  • Added a new icon for collection preferences in particular

This PR is still missing "Collection Object Creation", but not needed if we are implementing #7439?

@Gitesh307
Copy link
Contributor Author

There are a decent number of new changes, can you please review @Gitesh307?

  • Now Collection Preferences looks and works much more like User Preferences, with an added sidebar
  • Preference descriptions are now much more detailed and inline with the requirements
  • Descriptions and options use localized captions for table and field names, for both trees and CO inheritance
  • Added a new icon for collection preferences in particular

This PR is still missing "Collection Object Creation", but not needed if we are implementing #7439?

@grantfitzsimmons Yes, that’s correct, Collection Object Creation is pending #7439, so I’ve held off to avoid duplicate work. I can either leave it out for now or add a stub section if you want. Let me know.

@grantfitzsimmons
Copy link
Member

@Gitesh307 Feel free to leave it out for now (it can be done by manually editing the file for the time being)

@grantfitzsimmons grantfitzsimmons changed the title Feat(preferences): Add “Collection Preferences” page with role-gated access feat(preferences): Add “Collection Preferences” page with role-gated access Oct 20, 2025
@grantfitzsimmons grantfitzsimmons added this to the 7.12.0 milestone Oct 20, 2025
@grantfitzsimmons
Copy link
Member

@Gitesh307 Do you want to do another round of review before we invite testers?

@CarolineDenis CarolineDenis requested a review from a team October 20, 2025 20:59
Copy link
Member

@grantfitzsimmons grantfitzsimmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gitesh307 Gitesh307 force-pushed the issue-7440 branch 2 times, most recently from 9bddd66 to 2267248 Compare October 28, 2025 16:14
Triggered by 2267248 on branch refs/heads/issue-7440
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Dev Attention Needed

Development

Successfully merging this pull request may close these issues.

Refactor and add UI to control Collection preferences

6 participants