refactor: simplify code

Author: grantfitzsimmons

specifyweb/frontend/js_src/lib/components/Preferences/Editor.tsx

@@ -111,7 +111,7 @@ export const UserPreferencesEditor = createPreferencesEditor({
   Context: userPreferences.Context,
   resourceName: 'UserPreferences',
   fetchUrl: '/context/user_resource/',
-  developmentGlobal: '_editingUserPreferences',
+  developmentGlobal: 'editingUserPreferences',
   dependencyResolver: ({ onChange }) => [onChange],
 });
 
@@ -120,7 +120,7 @@ export const CollectionPreferencesEditor = createPreferencesEditor({
   Context: collectionPreferences.Context,
   resourceName: 'CollectionPreferences',
   fetchUrl: '/context/collection_resource/',
-  developmentGlobal: '_editingCollectionPreferences',
+  developmentGlobal: 'editingCollectionPreferences',
   prefType: 'collection',
   dependencyResolver: ({ data, onChange }) => [data, onChange],
 });

specifyweb/frontend/js_src/lib/components/Preferences/useTopChild.tsx

@@ -54,20 +54,10 @@ export function useTopChild(): {
 
     const observer = new ResizeObserver(handleChange);
     observer.observe(container);
-    const scrollTargets: HTMLElement[] = [];
-    for (
-      let element: HTMLElement | null = container;
-      element !== null;
-      element = element.parentElement
-    )
-      scrollTargets.push(element);
-    const uniqueScrollTargets = Array.from(new Set(scrollTargets));
-    const scrollCleanups = uniqueScrollTargets.map((target) =>
-      listen(target, 'scroll', handleChange)
-    );
+    const scroll = listen(container, 'scroll', handleChange);
     return (): void => {
       observer.disconnect();
-      scrollCleanups.forEach((cleanup) => cleanup());
+      scroll();
     };
   }, [container]);