CMake cleanup #58 #138
Merged
CMake cleanup #58 #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prevent having to explicitly run `uname` CMAKE_SYSTEM_PROCESSOR holds the output of `uname -p` which will be x86_64 on all x86_64 Linux machines, and another value on incompatible machines line OS X, arm, etc. - Since this is a CMake variable no scoping/inheritence etc. issues, or concerns about conditional definition etc.
- Fixes #58 The checks performed in the top level CMakeLists.txt are inherited whenever other CMake files are `include`d or `add_subdirectory`-d - `${opencoarrays_aware_compiler}` set in top level and inherited everywhere else
- Pass the `-fcoarray=single` flag to the builtin CMake macro
`CHECK_Fortran_SOURCE_COMPILES` from the `CheckFortranSourceCompiles`
builtin macro, using the standard `CMAKE_REQUIRED_FLAGS
Current coverage is
|
- OpenCoarraysConfig.cmake.in moved to `./cmake/pkg` - Updated cmake logic to be more robust against spaces, odd paths etc.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #58, mostly. Still some stuff left to do concerning cleaning up install directories, install logic, and improving/fixing the CMake project export capabilities. (This last feature is CMake's answer to pkg-config---It tells other CMake projects that want to use OpenCoarrays, what linker & compiler flags they need, where OC is installed, etc.)
A number of extraneous CMake files and syntax were removed. Enhancements include:
opencoarrays_aware_compilerindicating if the compiler is OCACMAKE_REQUIRED_FLAGSto pass-fcoarray=singleto the introspection fortran compiler invocations.