reduce build system redundancy

[zbeekman]

It seems that there are three CMakeListst.txt files that check compiler version etc. to set opencoarrays_aware_compiler. The top level CMakeLists.txt does this, then it happens again in the src/mpi/CMakeLists.txt and /src/tests/unit/extensions/CMakeLists.txt. Is there a reason this value can't simply be inherited from the top level CMakeLists.txt? This will ease the burden of maintaining which upstream software is compatible with which feature...

[zbeekman]

I meant to include this view of all the occurrences in my original post: https://github.com/sourceryinstitute/opencoarrays/search?utf8=✓&q=opencoarrays_aware_compiler

[rouson]

I very much look forward to any insight you have on how to reduce these redundancies. It is never been clear to me whether and how variable set in one CMake file can be accessed and in another CMake file other than through it include statement.

[zbeekman]

I'm pretty sure variables are inherited via add_directory(...), but need to double check...

Just FYI, I use these issues as TO-DO and reminders for the whole project, and to solicit feedback. I hope you don't mind the flurry of activity. Things will calm down once I'm up to speed and the work flow we implement comes into practice.

[rouson]

No worries. The flurry is a bit overwhelming, but it's for a great cause and I'm glad to hear that you expect it to slow down at some point -- that alone is good motivation for updating our practices. :)

Sent from my iPhone

On Dec 14, 2015, at 12:43 PM, Izaak Beekman notifications@github.com wrote:

I'm pretty sure variables are inherited via add_directory(...), but need to double check...

Just FYI, I use these issues as TO-DO and reminders for the whole project, and to solicit feedback. I hope you don't mind the flurry of activity. Things will calm down once I'm up to speed and the work flow we implement comes into practice.

—
Reply to this email directly or view it on GitHub.

[zbeekman]

This stack overflow answer confirms the documentation of the set command that add_subdirectory will cause CMakeLists.txt in subdirectories to inherit variables from the parent directory's CMakeLists.txt. (But note, this doesn't work the other way, variables set in subdirectories, are not added to the parent directory's scope, unless using the PARENT_SCOPE option to the set command.

[zbeekman]

this is relevant to #39