Skip to content

Redis adapter is not correctly cleaning up/unsubscribing topics when handling socketIO middleware errors #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Redis adapter is not correctly cleaning up/unsubscribing topics when handling socketIO middleware errors #508

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe34526
Add delAll adapter imlpementation
jminarik-atl Jul 17, 2023
0706dfa
Add noop commit to re-run bulds
jminarik-atl Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import uid2 = require("uid2");
import msgpack = require("notepack.io");
import { Adapter, BroadcastOptions, Room } from "socket.io-adapter";
import { Adapter, BroadcastOptions, Room, SocketId } from "socket.io-adapter";
import { PUBSUB } from "./util";

const debug = require("debug")("socket.io-redis");
Expand Down Expand Up @@ -941,6 +941,12 @@ export class RedisAdapter extends Adapter {
this.pubClient.off("error", this.friendlyErrorHandler);
this.subClient.off("error", this.friendlyErrorHandler);
}
delAll(id: SocketId) {
// Call parent adapter cleanup
super.delAll(id);
// Unsubscribe from Redis topics
this.close();
}
}

export { createShardedAdapter } from "./sharded-adapter";