Redis adapter is not correctly cleaning up/unsubscribing topics when handling socketIO middleware errors #508
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello, found a bug where redis adapter is not correctly cleaning up/unsubscribing topics when handling socketIO middleware errors:
next(new Error('Foo')
in a socketIO middleware (as suggested here), socketIO lib calls _cleanup on error hereleaveAll
, which is here and which calls adapter.delAlldelAll
here (it callsthis._del
in a loop)This causes leaking subscriptions on Redis servers of clients that are long gone.
Added a draft of what seems to fix the problem, though not sure whether this is the most correct approach, and also I don't know how to test this 🙈.