kn: enable many @IgnoreNative tests
#1233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
0marperez
approved these changes
Feb 6, 2025
Contributor
0marperez
left a comment
0marperez
left a comment
There was a problem hiding this comment.
Question: Will you remove the toList workaround before merging?
Comment on lines
+36
to
+37
| val clientTime = Instant.fromRfc5322("Fri, 6 Oct 2023 16:20:50 -0400") | ||
| val serverTime = Instant.fromRfc5322("Fri, 6 Oct 2023 16:20:50 -0400") |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…1238) * fix: correct hash code calculation for case-insensitive map entries * remove commented-out code
Affected ArtifactsChanged in size
|
ianbotsf
approved these changes
Feb 11, 2025
sugmanue
pushed a commit
to sugmanue/smithy-kotlin
that referenced
this pull request
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.