fix: ignore hop-by-hop headers when signing requests #1227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affected ArtifactsChanged in size
|
lauzadis
approved these changes
Jan 28, 2025
xinsong-cui
added a commit
that referenced
this pull request
Jan 31, 2025
* fix: add 0.9.x aws-crt-kotlin transform (#1220) * fix: Ensure `Host` header is included when signing auth tokens (#1222) * chore: release 1.4.1 * chore: bump snapshot version to 1.4.2-SNAPSHOT * fix: address various failing protocol tests (#1223) * misc: re-enable `kotlinWarningsAsErrors=true` (#1224) * fix: ignore hop-by-hop headers when signing requests (#1227) * chore: release 1.4.2 * chore: bump snapshot version to 1.4.3-SNAPSHOT * misc: add telemetry configuration to DefaultAwsSigner (#1226) * add telemetry provider configuration * lint * address pr reviews * add changelog --------- Co-authored-by: Matas <[email protected]> Co-authored-by: aws-sdk-kotlin-ci <[email protected]> Co-authored-by: Ian Botsford <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
(none)
Description of changes
This change adds headers defined by RFC 2616 § 13.5.1 as "hop-by-hop" headers to the ignore list for signing. This prevents signatures from becoming invalid if intervening proxies/caches alter the headers.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.