kn: HostResolver #1229
Merged
kn: HostResolver #1229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This reverts commit 272b6a0.
lauzadis
commented
Jan 31, 2025
runtime/build.gradle.kts
Outdated
| } | ||
| } | ||
|
|
||
| configureIosSimulatorTasks() |
Contributor
Author
There was a problem hiding this comment.
Note: Had to bump Gradle versions because of issues invoking this function:
* What went wrong:
Could not determine the dependencies of task ':runtime:crt-util:iosSimulatorArm64Test'.
> Could not create task ':runtime:crt-util:bootIosSimulatorDevice'.
> 'org.gradle.api.tasks.Exec org.gradle.api.tasks.Exec.setIgnoreExitValue(boolean)'
This comment has been minimized.
This comment has been minimized.
ianbotsf
approved these changes
Jan 31, 2025
Comment on lines
+36
to
+48
| val (size, addrPtr, constructor) = when (sa_family.toInt()) { | ||
| AF_INET -> Triple( | ||
| 4, | ||
| reinterpret<sockaddr_in>().sin_addr.ptr, | ||
| { bytes: ByteArray -> IpV4Addr(bytes) }, | ||
| ) | ||
| AF_INET6 -> Triple( | ||
| 16, | ||
| reinterpret<sockaddr_in6>().sin6_addr.ptr, | ||
| { bytes: ByteArray -> IpV6Addr(bytes) }, | ||
| ) | ||
| else -> throw IllegalArgumentException("Unsupported sockaddr family $sa_family") | ||
| } |
Contributor
There was a problem hiding this comment.
Comment: Nice! I wish non-Pair tuples were a bit easier to use in Kotlin but this is a great abstraction.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…ng. Ignore error code 148/149 in shutdown
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Affected ArtifactsChanged in size
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HostResolveron Native usinggetaddrinfoHostResolverIssue #
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.