-
Notifications
You must be signed in to change notification settings - Fork 9
Include DOM path when nesting in assertions #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
cf216df
trait and base assert
jackbayliss ccda583
tests and improvements
jackbayliss 627d792
test tests
jackbayliss 97c3908
Update DomTest.php
jackbayliss 4d66d56
Revert "test tests"
jackbayliss c89b722
diff bits
jackbayliss 189086f
Fix styling
jackbayliss fa06d94
Update DomTest.php
jackbayliss 7ee8854
Update UsesElementAsserts.php
jackbayliss 674697c
rename
jackbayliss 9495d6f
Merge branch 'dom-path' of https://github.com/jackbayliss/laravel-dom…
jackbayliss 485c11d
rename this too
jackbayliss 93eafd5
last
jackbayliss 044603f
Update TrackSelectors.php
jackbayliss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| <?php | ||
|
|
||
| namespace Sinnbeck\DomAssertions\Asserts\Traits; | ||
|
|
||
| trait TrackSelectors | ||
| { | ||
| protected array $selectorPath = []; | ||
|
|
||
| public function withSelectors(array $previousSelectors, string $currentSelector): self | ||
| { | ||
| $this->selectorPath = array_merge($previousSelectors, [$currentSelector]); | ||
|
|
||
| return $this; | ||
| } | ||
|
|
||
| public function getSelectors(): string | ||
| { | ||
| if (empty($this->selectorPath)) { | ||
| return '(root)'; | ||
| } | ||
|
|
||
| return implode(' > ', $this->selectorPath); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This basically tells it to use the current closures selectors, and track the new selector. Seemed the most simple this way, but feel free to change :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems all good :)