Include DOM path when nesting in assertions #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackbayliss
commented
Sep 28, 2025
| if (! is_null($callback)) { | ||
| $elementAssert = new AssertElement($this->getContent(), $element); | ||
|
|
||
| $elementAssert->withSelectors($this->selectorPath, $selector); |
There was a problem hiding this comment.
This basically tells it to use the current closures selectors, and track the new selector. Seemed the most simple this way, but feel free to change :)
jackbayliss
changed the title
|
Great idea. Will indeed make debugging way easier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently :
We can use and nest multiple
find()methods, but, when an issue occurs it's not always obvious where exactly it is when using factories etc..We end up with errors such as :
But, the issue is we could have numerous data providers etc-and many tests so it becomes difficult to debug.
Changes
This PR adds more context to the errors by including the selector paths ie:
Which helps direct us closer to where it is.. as the selectors are the same we've entered.
To do the above I've added a
TrackSelectorstrait to contain that logic - and added withwithSelectorsin thefind()method to keep track of all the selectors.We can probably alter more assertions to be more specific - but just done a few for now.