[Forwardport] Fix typo in securityCheckers array #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- codestyle fixes
Make imageUploader component
Make imageUploader component
Refactor test/add coverage for new functionality
Revert addition of storeManager to Magento\Catalog\Model\Category\Attribute\Backend\Image
Add test case to Magento\Catalog\Test\Unit\Model\Category\Attribute\Backend\ImageTest
Add image-uploader jasmine unit test
Add imageUploader to ConverterTest
Implement placeholder image/upload directions per comp
-fix integration test
Add spinner when uploaded image is being processed
Import _image-uploader.less
Add license to _image-uploader.less
Wrap text in translate
HTML-escape file attributes and use 'is' prefix for boolean return methods and assigned props
…pearing when preparing data Fix openDialogTitle appearance in config
Disable buttons if using default value (observable disabled prop is true)
Add dependency module-store to composer.json
Fix styles for image uploader preview
Fix JS static failures
Add TestModuleWysiwygConfig and integration test to assert modification of WYSIWYG config
Change openDialogTitle to Media Gallery
…torage Confine media gallery dropzone to [role="dialog"]
Fix spinner display when overwriting image
…torage Enforce validation on media gallery
…torage Remove unnecessary bind
Update other image uploaders throughout in Catalog, Email, Swatches, and Theme
…torage Interpret allowed extensions for media gallery file validation dynamically
Accepted Public Pull Requests: - magento#13783: [Forwardport] Add option to add IP address to existing list + add test (by @serhii-balko) - magento#13818: [Forwardport] Cast handling fee to float (by @serhii-balko) - magento#13819: [Forwardport] Fix bug Magento 2.2.2 password reset strength meter magento#13429 (by @serhii-balko) - magento#13785: [Forwardport] Remove forced setting of cache_lifetime to false in constructor and set default cache_lifetime to 3600 (by @nmalevanec) - magento#13786: [Forwardport] Add ObserverInterface to the api (by @nmalevanec) - magento#13788: [Forwardport] Add RewriteBase directive template in .htaccess file into pub/static folder (by @nmalevanec) - magento#13795: [Forwardport] Fixes magento#12791 - Use a selector to only select the correct tax rate sel (by @nmalevanec) - magento#13792: [Forwardport] Ensure DeploymentConfig Reader always returns an array (by @nmalevanec) - magento#13794: [Forwardport] Typo (address not addres) (by @nmalevanec) - magento#13741: [Forwardport] Add MagentoStyle as Console Input/output helper object to allow easier access to io helpers in symfony/console (by @nmalevanec) - magento#13439: [2.3] Product image builder - Override attributes when builder used multiple times (by @ihor-sviziev) - magento#13687: Change the way the minify_exclude configurations can be used. (by @hostep) Fixed GitHub Issues: - magento#13429: Magento 2.2.2 password reset strength meter (reported by @zukovasmartynas) has been fixed in magento#13819 by @serhii-balko in 2.3-develop branch Related commits: 1. 99b32cf 2. fd5e0b5 - magento#13595: loadCache for Block Magento\Theme\Block\Html\Footer dont work (reported by @larsroettig) has been fixed in magento#13785 by @nmalevanec in 2.3-develop branch Related commits: 1. 53c7321 2. 2407845 - magento#12791: Customer & Product Tax class wrongly styled (reported by @duckchip) has been fixed in magento#13795 by @nmalevanec in 2.3-develop branch Related commits: 1. 37a3794 - magento#11577: TinyMCE (WYSIWYG) doesn't work in admin when JS minify is enabled (reported by @jordy2607) has been fixed in magento#13687 by @hostep in 2.3-develop branch Related commits: 1. d1f1252
…serComponentRegistration.php to fix broken upgrades from previous versions
- Added tests to create pagebuilder product attribute from product form
- merged latest code from mainline branch
Accepted Public Pull Requests: - magento-engcom/php-7.2-support#39: Update colinmollenhour/php-redis-session-abstract (by @pmclain)
-fix architects comments
-fix unit tests
…4-rename-registration-php
-fix api-functional tests
…'config:set' magento#13832 - Merge Pull Request magento#13832 from nmalevanec/magento2:2.3-develop-PR-port-13280 - Merged commits: 1. 9ca5d97
-fix mftf tests
…ial characters magento#13784 - Merge Pull Request magento#13784 from serhii-balko/magento2:2.3-develop-PR-port-12749 - Merged commits: 1. f3e10a7 2. 6d1cd8d
…tribute [Team3] Adding custom attribute
…4-rename-registration-php
…e-registration-php [borg] MAGETWO-88314: Base composer.json autoload changes break upgrades
- merged latest code from mainline branch
Accepted Public Pull Requests: - magento-engcom/import-export-improvements#99: product images with same name overwrite previous image fix (by @umarch06) - magento#13784: [Forwardport] Grid filtration doesn't work for mysql special characters (by @serhii-balko) - magento#13832: [Forwardport] Add option "lock-config" for shell command "config:set" (by @nmalevanec) - magento#11572: Add The Ability To Limit Autocomplete Results (by @mpchadwick)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#13897
Description
Update
wuantitytoquantityto match the key used in https://github.com/magento/magento2/blob/4cfedb97d92b887e68a8d9c2f14bf75f1854ba0c/app/code/Magento/Security/etc/di.xmlFixed Issues (if relevant)
n/a
Manual testing scenarios
Contribution checklist