Skip to content

Conversation

@serhii-balko
Copy link
Contributor

Original Pull Request

#12749

Manual testing scenarios

  1. Create several products
  2. Open product grid
  3. Open filters block
  4. Enter % or _ to name field
  5. Do filter

###Expected result

Grid shows only products with the symbol

###Actual result

Grid shows all products

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

  - added escaping for filter input value
  - test has been fixed.
  - new test-case has been added.
@ihor-sviziev
Copy link
Contributor

Hi @serhii-balko,
Thank you for your work. Unfortunately we have older PR #13780 with the same changes, so we can't accept your one.

I'll mark your PR as duplicate

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
MAGETWO-88260 has been created to process this Pull Request

@ihor-sviziev ihor-sviziev reopened this Feb 22, 2018
@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Feb 22, 2018

@serhii-balko Looks like testing was started, so it's better to accept your PR. I'm re-opening it

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-591 has been created to process this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants