Skip to content

Conversation

@laconica-sergey
Copy link
Contributor

Manual testing scenarios

  1. Create several products
  2. Open product grid
  3. Open filters block
  4. Enter % or _ to name field
  5. Do filter

###Expected result

Grid shows only products with the symbol

###Actual result

Grid shows all products

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

  - added escaping for filter input value
  - test has been fixed.
  - new test-case has been added.
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Dec 15, 2017

CLA assistant check
All committers have signed the CLA.

@avoelkl avoelkl self-assigned this Dec 18, 2017
@avoelkl avoelkl added this to the December 2017 milestone Dec 19, 2017
@avoelkl
Copy link
Contributor

avoelkl commented Jan 3, 2018

Hi @laconica-sergey,
Thanks for the PR!
I just tried to test and reproduce any, anyway it seems this is already working on the latest 2.2-develop branch.

See my screenshots below. Can you please give me some more information where/how this is not working? Thanks!

In this case I added two products:
Samsung Galaxy S8 G950F and
Samsung Galaxy% S8+ G955F

Samung%
bildschirmfoto 2018-01-03 um 20 54 48

Samsung_
bildschirmfoto 2018-01-03 um 20 54 30

@avoelkl avoelkl added Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Progress: needs update labels Jan 3, 2018
@avoelkl
Copy link
Contributor

avoelkl commented Jan 8, 2018

Any update on my previous question @laconica-sergey?

@igrybkov
Copy link
Contributor

igrybkov commented Jan 8, 2018

Hi @avoelkl,

You actually reproduced the issue: the filter doesn't apply, and your search disrespects special character in the search phrase. Search for the term 'Samsung%' should show nothing in your case and search by the phrase 'Galaxy%' should show only one product with the exact match.

To make it clear, try to search by the '%' sign — you will see both products, but the only one actually should match this search.

@ihor-sviziev ihor-sviziev self-assigned this Feb 19, 2018
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
MAGETWO-85827 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 17a817c into magento:2.2-develop Feb 22, 2018
@ihor-sviziev ihor-sviziev removed the Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch label Feb 22, 2018
@ihor-sviziev ihor-sviziev added mageconf Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release labels Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants