[Forwardport] Ensure DeploymentConfig Reader always returns an array #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sv file with semicolon delimiter[forwardport].
Without getName(), __toString() is triggered, which creates a string representation of the whole class and apparently also can lead to errors
- Analytics - Authorization - Braintree - Bundle - Eav (EavSetup refactoring only)
- Analytics - Authorization - Braintree - Bundle - Eav (EavSetup refactoring only) - Catalog
- Catalog - CatalogInventory - CatalogRule - CatalogUrlRewrite - CatalogSearch
- ConfigurableProduct
- CurrencySymbol
…ariable magento#13733 - Merge Pull Request magento#13733 from nmalevanec/magento2:2.3-develop-PR-port-13663 - Merged commits: 1. 44940be
[performance] MAGETWO-87675: FATAL error on compiler generation on PHP 7.0.11
Cover code changes with unit test.
…lection magento#13735 - Merge Pull Request magento#13735 from nmalevanec/magento2:2.3-develop-PR-port-13596 - Merged commits: 1. 310e450 2. d5114a8
Fixed issue: MAGETWO-87619 Add ability minify html when SCD on demand in production is enabled
…nto MAGETWO-87551
[trigger] MAGETWO-86717: Data Patches conversion
- MQE-798: Fix MFTF modules missing from composer install
…in case of misspelt module name magento#13731
…od getUrl in Magento\Catalog\Model\Product\Attribute\Frontend\Image magento#13635
…patible with jQuery 3.* magento#13686
…csv file with semicolon delimiter[forwardport]. magento#1203
Accepted Public Pull Requests: - magento#13735: [Forwardport] Fix adding values to system variable collection (by @nmalevanec) - magento#13733: [Forwardport] Refactoring: remove unuseful temporary variable (by @nmalevanec) - magento#13731: [Forwardport] Display a more meaningful error message in case of misspelt module name (by @nmalevanec) - magento#13727: [Forwardport] Show maintenance IP-address without commas (by @nmalevanec) - magento#13729: [Forwardport] Update StorageInterface.php (by @nmalevanec) - magento#13635: [Forwardport] magento#13498 issue magento#13497 - Method getUrl in Magento\Catalog\Model\Product\Attribute\Frontend\Image (by @nmalevanec) - magento#13686: magento#13685: Replaced .size() with .length to be compatible with jQuery 3.* (by @kirmorozov) - magento-engcom/magento2ce#1203: Report error csv doesn't work when trying to import a csv file with semicolon delimiter[forwardport]. (by @nmalevanec) - magento#13361: Fix URL passed to static.php in PHP in-development server (by @nieltg) Fixed GitHub Issues: - magento#5015: Report error csv doesn't work when trying to import a csv file with semicolon delimiter (reported by @agoeurysky) has been fixed in magento-engcom/magento2ce#1203 by @nmalevanec in 2.3-develop branch Related commits: 1. 7c03614
Accepted Public Pull Requests: - magento#13308: Improve getCustomAttribute() performance (by @schmengler)
…n on invalid config
sidolov
force-pushed
the
2.3-develop-PR-port-13584
branch
from
d18de30 to
f0e15b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#13584
Description
When a empty configuration file is ready, this could result in loading invalid configuration, eg. just
1instead of an array. This will lead to problems with other code, expecting a valid array.Fixed Issues
magento/pull/13090
Manual testing scenarios
Create an empty file as app/etc/env.php and run the CLI installer