[Forwardport] Display a more meaningful error message in case of misspelt module name #13731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[LogicException] Component 'VendorA_ModuleB' of type '' is not correctly registered. instead of [Magento\Framework\Exception\FileSystemException] The file "/composer.json" doesn't exist
…pelled module name. Cover new code with tests.
Contributor
|
Hi @nmalevanec your changes looks good for me. Also I see that you covered these changes with unit test (that was missing in 2.2-develop branch). Could you create separate PR to 2.2-develop branch with adding test? |
ihor-sviziev
approved these changes
Feb 19, 2018
Contributor
|
Hi @ihor-sviziev, thank you for the review. |
4 tasks
Contributor
Author
|
@ihor-sviziev, done. #13740 |
Contributor
|
@nmalevanec thank you! |
magento-engcom-team
pushed a commit
that referenced
this pull request
Feb 21, 2018
…in case of misspelt module name #13731
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#12843
Description
Displays a more meaningful error message in case of misspelt module name.
[LogicException] Component 'VendorA_ModuleB' of type '' is not correctly registered.instead of
[Magento\Framework\Exception\FileSystemException] The file "/composer.json" doesn't existManual testing scenarios
bin/magento module:disable Magento_Bundle(orbin/magento module:enable Magento_Bundle, if it is disabled); yes, it does not have to be the same incorrectly configured module, any will do.