Skip to content
This repository was archived by the owner on Dec 9, 2024. It is now read-only.

chore: update @types dependencies #673

Closed
wants to merge 7 commits into from
Closed

chore: update @types dependencies #673

wants to merge 7 commits into from

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented May 29, 2023

What did you implement:

  • removed unneeded @types dependencies
    • @types/lodash should have been removed as part of refactor: remove lodash #670
    • @types/xml I assume was added by mistake at some point
    • @types/open have been deprecated because the latest version of open ships with types
  • updated existing @types dependencies except for @types/serverless because that causes a lot of errors (which I suspect have the same root cause, but best tackled in its own PR)
  • added some missing types
    • mock-spawn and zip-folder don't have any types though

How did you implement it:

Adjusting the contents of package.json and running npm install

How can we verify it:

By running npx tsc --noemit

Todos:

Note: Run npm run test:ci to run all validation checks on proposed changes

  • Ensure there are no lint errors.
    Validate via npm run lint
    Note: Some reported issues can be automatically fixed by running npm run lint:fix
  • Write tests and confirm existing functionality is not broken.
    Validate via npm test
  • Write documentation
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@G-Rath G-Rath changed the title chore: remove unneeded @types dependencies chore: update @types dependencies May 29, 2023
@G-Rath G-Rath marked this pull request as draft May 29, 2023 18:57
@G-Rath G-Rath marked this pull request as ready for review May 29, 2023 19:23
@G-Rath G-Rath closed this by deleting the head repository Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant