This repository was archived by the owner on Dec 9, 2024. It is now read-only.
chore: update @types
dependencies
#673
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
@types
dependencies@types/lodash
should have been removed as part of refactor: removelodash
#670@types/xml
I assume was added by mistake at some point@types/open
have been deprecated because the latest version ofopen
ships with types@types
dependencies except for@types/serverless
because that causes a lot of errors (which I suspect have the same root cause, but best tackled in its own PR)mock-spawn
andzip-folder
don't have any types thoughHow did you implement it:
Adjusting the contents of
package.json
and runningnpm install
How can we verify it:
By running
npx tsc --noemit
Todos:
Note: Run
npm run test:ci
to run all validation checks on proposed changesValidate via
npm run lint
Note: Some reported issues can be automatically fixed by running
npm run lint:fix
Validate via
npm test
Is this ready for review?: YES
Is it a breaking change?: NO