Skip to content
This repository was archived by the owner on Dec 9, 2024. It is now read-only.

refactor: remove lodash #670

Merged
merged 3 commits into from
May 25, 2023
Merged

refactor: remove lodash #670

merged 3 commits into from
May 25, 2023

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented May 21, 2023

What did you implement:

Removed lodash as a required dependency for this plugin.

How did you implement it:

I replaced the single usage of lodash with a native equivalent, and then I removed it from dependencies in package.json

How can we verify it:

❯ rg --files-with-matches 'lodash'
integrationTests/configurations/node16-linux-webpack/package-lock.json
integrationTests/configurations/node12-linux/package-lock.json
integrationTests/configurations/node18-linux-webpack/package-lock.json
integrationTests/configurations/node14-windows/package-lock.json
integrationTests/configurations/node16-linux/package-lock.json
integrationTests/configurations/node12-linux-webpack/package-lock.json
integrationTests/configurations/node18-windows-webpack/package-lock.json
integrationTests/configurations/node16-windows-webpack/package-lock.json
integrationTests/configurations/node14-windows-webpack/package-lock.json
integrationTests/configurations/node16-windows/package-lock.json
integrationTests/configurations/node18-windows/package-lock.json
integrationTests/configurations/node12-windows-webpack/package-lock.json
integrationTests/configurations/node12-windows/package-lock.json
integrationTests/configurations/node14-linux-webpack/package-lock.json
integrationTests/configurations/node14-linux/package-lock.json
integrationTests/configurations/node18-linux/package-lock.json
examples/typescript-webpack/package-lock.json
package-lock.json

If lodash was being used by this package, then there should have been a match in either a TypeScript or JavaScript file, which there was not.

The tests also will fail if lodash is actually still needed.

Todos:

Note: Run npm run test:ci to run all validation checks on proposed changes

  • Ensure there are no lint errors.
    Validate via npm run lint
    Note: Some reported issues can be automatically fixed by running npm run lint:fix
  • Write tests and confirm existing functionality is not broken.
    Validate via npm test
  • Write documentation
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@G-Rath G-Rath mentioned this pull request May 21, 2023
6 tasks
@gligorkot gligorkot merged commit bba1346 into serverless:master May 25, 2023
@G-Rath G-Rath mentioned this pull request May 29, 2023
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants