[PLATFORM-2861] Move SauceLabs tests to a different steps in CircleCI #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2prateek
reviewed
Jun 30, 2018
| - run: | ||
| name: Run tests | ||
| command: make test | ||
| name: Authenticate npm |
There was a problem hiding this comment.
is this required if it is already done in the setup phase?
Contributor
Author
There was a problem hiding this comment.
Yeah, we don't cache the npm config file (the one that gets updated with npm login). I'll ask security if we could do it.
f2prateek
reviewed
Jun 30, 2018
| name: Run coverage | ||
| command: make coverage | ||
| name: Coverage | ||
| command: yarn coverage |
There was a problem hiding this comment.
I think coverage should run after test?
f2prateek
reviewed
Jun 30, 2018
| jobs: | ||
| - setup | ||
| - test: | ||
| - conventions: |
There was a problem hiding this comment.
conventions sounds like a weird name for this. I think the jobs should be named for what they're doing.
Contributor
Author
There was a problem hiding this comment.
Yeah, that's true, I'll open a new PR to address that. I'm going to add coverage and lint to test_phantomjs
nettofarah
pushed a commit
that referenced
this pull request
Feb 1, 2021
* elevio * kenshoo-infinity * optimizely * segmentio * taplytics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLATFORM-2861