Remove ndhoule/keys in favor of Object.keys (#26)

* elevio

* kenshoo-infinity

* optimizely

* segmentio

* taplytics

Author: Julio Farah

integrations/elevio/lib/index.js

@@ -3,7 +3,6 @@
 var integration = require('@segment/analytics.js-integration');
 var tick = require('next-tick');
 var objCase = require('obj-case');
-var objectKeys = require('@ndhoule/keys');
 
 /**
  * Expose `Elevio` integration.
@@ -64,7 +63,7 @@ Elevio.prototype.identify = function(identify) {
   if (name) user.name = name;
   if (plan) user.plan = [plan];
   if (plan) user.groups = [plan];
-  if (objectKeys(traits).length > 0) user.traits = traits;
+  if (Object.keys(traits).length > 0) user.traits = traits;
   window._elev.user = user;
   if (typeof window._elev.setUser === 'function') {
     window._elev.setUser(user);

integrations/elevio/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@segment/analytics.js-integration-elevio",
   "description": "The Elevio analytics.js integration.",
-  "version": "2.3.1",
+  "version": "2.3.2",
   "keywords": [
     "analytics.js",
     "analytics.js-integration",
@@ -24,7 +24,6 @@
     "url": "git+https://github.com/segmentio/analytics.js-integrations.git"
   },
   "dependencies": {
-    "@ndhoule/keys": "^2.0.0",
     "@segment/analytics.js-integration": "^3.3.2",
     "next-tick": "^1.0.0",
     "obj-case": "^0.2.0"

integrations/kenshoo-infinity/lib/index.js

@@ -8,7 +8,6 @@ var integration = require('@segment/analytics.js-integration');
 var reject = require('reject');
 var remove = require('obj-case').del;
 var extend = require('@ndhoule/extend');
-var keys = require('@ndhoule/keys');
 var trample = require('@segment/trample');
 
 /**
@@ -115,7 +114,7 @@ function limitChars(string, limit) {
 function format(properties) {
   var ret = {};
   // Sort keys alphabetically and take the first 15
-  var sortedKeys = keys(properties)
+  var sortedKeys = Object.keys(properties)
     .sort()
     .slice(0, 15);
   sortedKeys.forEach(function(key) {

integrations/kenshoo-infinity/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@segment/analytics.js-integration-kenshoo-infinity",
   "description": "The Kenshoo Infinity analytics.js integration.",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "keywords": [
     "analytics.js",
     "analytics.js-integration",
@@ -26,7 +26,6 @@
   "homepage": "https://github.com/segmentio/analytics.js-integrations/blob/master/integrations/kenshoo-infinity#readme",
   "dependencies": {
     "@ndhoule/extend": "^2.0.0",
-    "@ndhoule/keys": "^2.0.0",
     "@segment/analytics.js-integration": "^3.3.2",
     "@segment/trample": "^0.2.0",
     "obj-case": "^0.2.0",

integrations/optimizely/lib/index.js

@@ -4,7 +4,6 @@
  * Module dependencies.
  */
 
-var keys = require('@ndhoule/keys');
 var values = require('@ndhoule/values');
 var foldl = require('@ndhoule/foldl');
 var integration = require('@segment/analytics.js-integration');
@@ -202,7 +201,7 @@ Optimizely.prototype.sendClassicDataToSegment = function(experimentState) {
   );
 
   // Sorting for consistency across browsers
-  var variationIds = keys(variationsMap).sort();
+  var variationIds = Object.keys(variationsMap).sort();
   var variationNames = values(variationsMap).sort();
 
   // Send data via `.track()`
@@ -248,7 +247,7 @@ Optimizely.prototype.sendClassicDataToSegment = function(experimentState) {
       }
 
       // Sorting for consistency across browsers
-      props.sectionId = keys(activeSections)
+      props.sectionId = Object.keys(activeSections)
         .sort()
         .join(); // Not adding space for backward compat/consistency reasons since all IDs we've never had spaces
       props.sectionName = values(activeSections)
@@ -338,7 +337,7 @@ Optimizely.prototype.sendNewDataToSegment = function(campaignState) {
   );
 
   // Sorting for consistency across browsers
-  var audienceIds = keys(audiencesMap)
+  var audienceIds = Object.keys(audiencesMap)
     .sort()
     .join(); // Not adding space for backward compat/consistency reasons since all IDs we've never had spaces
   var audienceNames = values(audiencesMap)

integrations/optimizely/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@segment/analytics.js-integration-optimizely",
   "description": "The Optimizely analytics.js integration.",
-  "version": "3.5.1",
+  "version": "3.5.2",
   "keywords": [
     "analytics.js",
     "analytics.js-integration",
@@ -25,7 +25,6 @@
   },
   "dependencies": {
     "@ndhoule/foldl": "^2.0.1",
-    "@ndhoule/keys": "^2.0.0",
     "@ndhoule/values": "^2.0.1",
     "@segment/analytics.js-integration": "^3.3.2",
     "global-queue": "^1.0.1",

integrations/segmentio/lib/index.js

@@ -9,7 +9,6 @@ var clone = require('component-clone');
 var JSCookie = require('js-cookie');
 var extend = require('@ndhoule/extend');
 var integration = require('@segment/analytics.js-integration');
-var keys = require('@ndhoule/keys');
 var localstorage = require('yields-store');
 var protocol = require('@segment/protocol');
 var send = require('@segment/send-json');
@@ -327,7 +326,7 @@ Segment.prototype.normalize = function(message) {
     msg._metadata = { failedInitializations: failedInitializations };
   }
   if (this.options.addBundledMetadata) {
-    var bundled = keys(this.analytics.Integrations);
+    var bundled = Object.keys(this.analytics.Integrations);
     msg._metadata = msg._metadata || {};
     msg._metadata.bundled = bundled;
     msg._metadata.unbundled = this.options.unbundledIntegrations;

integrations/segmentio/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@segment/analytics.js-integration-segmentio",
   "description": "The Segmentio analytics.js integration.",
-  "version": "4.2.7",
+  "version": "4.2.8",
   "keywords": [
     "analytics.js",
     "analytics.js-integration",
@@ -25,7 +25,6 @@
   },
   "dependencies": {
     "@ndhoule/extend": "^2.0.0",
-    "@ndhoule/keys": "^2.0.0",
     "@segment/ad-params": "^1.0.0",
     "@segment/analytics.js-integration": "^3.3.2",
     "@segment/localstorage-retry": "^1.2.2",

integrations/taplytics/lib/index.js

@@ -6,7 +6,6 @@
 
 var integration = require('@segment/analytics.js-integration');
 var is = require('is');
-var keys = require('@ndhoule/keys');
 var push = require('global-queue')('_tlq');
 
 /**
@@ -62,7 +61,7 @@ Taplytics.prototype.identify = function(identify) {
 
   if (userId) attrs.id = userId;
 
-  if (keys(attrs).length) {
+  if (Object.keys(attrs).length) {
     push('identify', attrs);
   }
 };
@@ -85,7 +84,7 @@ Taplytics.prototype.group = function(group) {
   if (traits) attrs.groupTraits = traits;
   if (userId) attrs.id = userId;
 
-  if (keys(attrs).length) push('identify', attrs);
+  if (Object.keys(attrs).length) push('identify', attrs);
 };
 
 /**

integrations/taplytics/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@segment/analytics.js-integration-taplytics",
   "description": "The Taplytics analytics.js integration.",
-  "version": "2.0.1",
+  "version": "2.0.2",
   "keywords": [
     "analytics.js",
     "analytics.js-integration",
@@ -24,7 +24,6 @@
     "url": "git+https://github.com/segmentio/analytics.js-integrations.git"
   },
   "dependencies": {
-    "@ndhoule/keys": "^2.0.0",
     "@segment/analytics.js-integration": "^3.3.2",
     "global-queue": "^1.0.1",
     "is": "^3.1.0"