Skip to content

Commit 7bed520

Browse files
author
Julio Farah
authored
Remove ndhoule/map in favor of native function (#25)
* adobe-analytics * adometry * adroll * omniture
1 parent ffdd49c commit 7bed520

File tree

7 files changed

+10
-17
lines changed

7 files changed

+10
-17
lines changed

‎integrations/adobe-analytics/package.json‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@segment/analytics.js-integration-adobe-analytics",
33
"description": "The Adobe Analytics analytics.js integration.",
4-
"version": "1.16.3",
4+
"version": "1.16.4",
55
"keywords": [
66
"analytics.js",
77
"analytics.js-integration",
@@ -27,7 +27,6 @@
2727
},
2828
"dependencies": {
2929
"@ndhoule/extend": "^2.0.0",
30-
"@ndhoule/map": "^2.0.1",
3130
"@segment/analytics.js-integration": "^3.3.2",
3231
"@segment/to-iso-string": "^1.0.1",
3332
"@segment/trample": "^0.2.0",

‎integrations/adometry/lib/index.js‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
var entries = require('@ndhoule/entries');
88
var extend = require('@ndhoule/extend');
99
var integration = require('@segment/analytics.js-integration');
10-
var map = require('@ndhoule/map');
1110
var pick = require('@ndhoule/pick');
1211
var values = require('@ndhoule/values');
1312

@@ -106,8 +105,8 @@ Adometry.prototype._hashify = function(props, prefix) {
106105

107106
return (
108107
';' +
109-
map(function(prop) {
108+
props.map(function(prop) {
110109
return prefix + prop[0] + ':' + prop[1];
111-
}, props).join(';')
110+
}).join(';')
112111
);
113112
};

‎integrations/adometry/package.json‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@segment/analytics.js-integration-adometry",
33
"description": "The Adometry analytics.js integration.",
4-
"version": "2.0.1",
4+
"version": "2.0.2",
55
"keywords": [
66
"analytics.js",
77
"analytics.js-integration",
@@ -26,7 +26,6 @@
2626
"dependencies": {
2727
"@ndhoule/entries": "^2.0.0",
2828
"@ndhoule/extend": "^2.0.0",
29-
"@ndhoule/map": "^2.0.1",
3029
"@ndhoule/pick": "^2.0.0",
3130
"@ndhoule/values": "^2.0.1",
3231
"@segment/analytics.js-integration": "^3.3.2"

‎integrations/adroll/lib/index.js‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
var foldl = require('@ndhoule/foldl');
88
var integration = require('@segment/analytics.js-integration');
9-
var map = require('@ndhoule/map');
109
var snake = require('to-snake-case');
1110
var useHttps = require('use-https');
1211

@@ -102,7 +101,7 @@ AdRoll.prototype.track = function(track) {
102101
// If this is an unmapped event, fall back on a snakeized event name
103102
if (!events.length) events = [track.event()];
104103
// legacy (v1) behavior is to snakeize all mapped `events` values
105-
events = map(snake, events);
104+
events = events.map(snake);
106105
}
107106

108107
if (userId) data.user_id = userId;
@@ -132,7 +131,7 @@ AdRoll.prototype.productViewed = AdRoll.prototype.productAdded = function(
132131
// If this is an unmapped event, fall back on a snakeized event name
133132
if (!events.length) events = [track.event()];
134133
// legacy (v1) behavior is to snakeize all mapped `events` values
135-
events = map(snake, events);
134+
events = events.map(snake);
136135
}
137136

138137
if (userId) data.user_id = userId;
@@ -164,7 +163,7 @@ AdRoll.prototype.orderCompleted = function(track) {
164163
// If this is an unmapped event, fall back on a snakeized event name
165164
if (!events.length) events = [track.event()];
166165
// legacy (v1) behavior is to snakeize all mapped `events` values
167-
events = map(snake, events);
166+
events = events.map(snake);
168167
}
169168

170169
if (userId) data.user_id = userId;

‎integrations/adroll/package.json‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@segment/analytics.js-integration-adroll",
33
"description": "The Adroll analytics.js integration.",
4-
"version": "2.2.1",
4+
"version": "2.2.2",
55
"keywords": [
66
"analytics.js",
77
"analytics.js-integration",
@@ -25,7 +25,6 @@
2525
},
2626
"dependencies": {
2727
"@ndhoule/foldl": "^2.0.1",
28-
"@ndhoule/map": "^2.0.1",
2928
"@segment/analytics.js-integration": "^3.3.2",
3029
"to-snake-case": "^1.0.0",
3130
"use-https": "^0.1.1"

‎integrations/omniture/lib/index.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
var dot = require('obj-case');
88
var integration = require('@segment/analytics.js-integration');
99
var iso = require('@segment/to-iso-string');
10-
var map = require('@ndhoule/map');
1110
var type = require('type-of');
1211

1312
/**
@@ -198,7 +197,7 @@ Omniture.prototype.track = function(track) {
198197
} else {
199198
var products = properties.products;
200199
if (products && type(products) === 'array') {
201-
var productStrings = map(formatProduct, products);
200+
var productStrings = products.map(formatProduct);
202201
update(productStrings.join(', '), 'products');
203202
}
204203
}

‎integrations/omniture/package.json‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@segment/analytics.js-integration-omniture",
33
"description": "The Omniture analytics.js integration.",
4-
"version": "2.2.0",
4+
"version": "2.2.1",
55
"keywords": [
66
"analytics.js",
77
"analytics.js-integration",
@@ -26,7 +26,6 @@
2626
},
2727
"dependencies": {
2828
"@ndhoule/each": "^2.0.1",
29-
"@ndhoule/map": "^2.0.1",
3029
"@segment/analytics.js-integration": "^3.3.2",
3130
"@segment/to-iso-string": "^1.0.1",
3231
"obj-case": "^0.2.0",

0 commit comments

Comments
 (0)