Remove component-cookie in favor of js-cookies (#24)

* pardot

* vero

* segmentio

Author: Julio Farah

integrations/pardot/lib/index.js

@@ -4,7 +4,7 @@
  * Module dependencies.
  */
 
-var cookie = require('component-cookie');
+var cookie = require('js-cookie');
 var integration = require('@segment/analytics.js-integration');
 var load = require('@segment/load-script');
 var querystring = require('component-querystring');
@@ -93,9 +93,9 @@ Pardot.prototype.getRequestVariables = function() {
   var variables = {
     account_id: window.piAId,
     campaign_id: window.piCId,
-    pi_opt_in: cookie('pi_opt_in' + (this.options.piAId - 1e3)),
+    pi_opt_in: cookie.get('pi_opt_in' + (this.options.piAId - 1e3)),
     ver: 3,
-    visitor_id: cookie('visitor_id' + (this.options.piAId - 1e3))
+    visitor_id: cookie.get('visitor_id' + (this.options.piAId - 1e3))
   };
 
   // get all the query parameters

integrations/pardot/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@segment/analytics.js-integration-pardot",
   "description": "The Pardot analytics.js integration.",
-  "version": "2.0.1",
+  "version": "2.0.2",
   "keywords": [
     "analytics.js",
     "analytics.js-integration",
@@ -26,7 +26,7 @@
   "dependencies": {
     "@segment/analytics.js-integration": "^3.3.2",
     "@segment/load-script": "^1.0.1",
-    "component-cookie": "^1.1.2",
+    "js-cookie": "^2.2.1",
     "component-querystring": "^1.3.3",
     "use-https": "^0.1.1"
   },

integrations/segmentio/lib/index.js

@@ -6,7 +6,7 @@
 
 var ads = require('@segment/ad-params');
 var clone = require('component-clone');
-var cookie = require('component-cookie');
+var JSCookie = require('js-cookie');
 var extend = require('@ndhoule/extend');
 var integration = require('@segment/analytics.js-integration');
 var keys = require('@ndhoule/keys');
@@ -24,7 +24,7 @@ var Queue = require('@segment/localstorage-retry');
 
 var cookieOptions = {
   // 1 year
-  maxage: 31536000000,
+  maxage: '31536000000',
   secure: false,
   path: '/'
 };
@@ -64,6 +64,21 @@ var Segment = (exports = module.exports = integration('Segment.io')
   .option('addBundledMetadata', false)
   .option('unbundledIntegrations', []));
 
+var cookie = function(name, value, options){
+  switch (arguments.length) {
+    case 3:
+    case 2:
+      if (value === null) {
+        return JSCookie.remove(name, { path: ''})
+      }
+      return JSCookie.set(name, value, options);
+    case 1:
+      return JSCookie.get(name);
+    default:
+      return JSCookie.get();
+  }
+};
+
 /**
  * Get the store.
  *

integrations/segmentio/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@segment/analytics.js-integration-segmentio",
   "description": "The Segmentio analytics.js integration.",
-  "version": "4.2.6",
+  "version": "4.2.7",
   "keywords": [
     "analytics.js",
     "analytics.js-integration",
@@ -34,7 +34,7 @@
     "@segment/top-domain": "^3.0.0",
     "@segment/utm-params": "^2.0.0",
     "component-clone": "^0.2.2",
-    "component-cookie": "^1.1.2",
+    "js-cookie": "^2.2.1",
     "component-type": "^1.2.1",
     "uuid": "^2.0.2",
     "yields-store": "^1.0.2"

integrations/segmentio/test/index.test.js

@@ -3,7 +3,7 @@
 var Analytics = require('@segment/analytics.js-core').constructor;
 var Segment = require('../lib/');
 var assert = require('proclaim');
-var cookie = require('component-cookie');
+var JSCookie = require('js-cookie');
 var integration = require('@segment/analytics.js-integration');
 var protocol = require('@segment/protocol');
 var sandbox = require('@segment/clear-env');
@@ -21,6 +21,23 @@ var lolex = require('lolex');
 // this hackery
 var isPhantomJS = /PhantomJS/.test(window.navigator.userAgent);
 
+
+var cookie = function(name, value, options){
+  switch (arguments.length) {
+    case 3:
+    case 2:
+      if (value === null) {
+        return JSCookie.remove(name, { path: ''})
+      }
+      return JSCookie.set(name, value, options);
+    case 1:
+      return JSCookie.get(name);
+    default:
+      return JSCookie.get();
+  }
+};
+
+
 describe('Segment.io', function() {
   var segment;
   var analytics;

integrations/vero/lib/index.js

@@ -4,7 +4,7 @@
  * Module dependencies.
  */
 
-var cookie = require('component-cookie');
+var cookie = require('js-cookie');
 var integration = require('@segment/analytics.js-integration');
 var push = require('global-queue')('_veroq');
 
@@ -31,7 +31,7 @@ Vero.prototype.initialize = function() {
   // basically, they have window.addEventListener('unload')
   // which then saves their "command_store", which is an array.
   // so we just want to create that initially so we can reload the tests.
-  if (!cookie('__veroc4')) cookie('__veroc4', '[]');
+  if (!cookie.get('__veroc4')) cookie.set('__veroc4', '[]');
   push('init', { api_key: this.options.apiKey });
   this.load(this.ready);
 };

integrations/vero/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@segment/analytics.js-integration-vero",
   "description": "The Vero analytics.js integration.",
-  "version": "2.2.0",
+  "version": "2.2.1",
   "keywords": [
     "analytics.js",
     "analytics.js-integration",
@@ -25,7 +25,7 @@
   },
   "dependencies": {
     "@segment/analytics.js-integration": "^3.3.2",
-    "component-cookie": "^1.1.2",
+    "js-cookie": "^2.2.1",
     "global-queue": "^1.0.1"
   },
   "devDependencies": {

yarn.lock

@@ -6736,6 +6736,11 @@ jquery@^2.2.4:
   resolved "https://registry.yarnpkg.com/jquery/-/jquery-2.2.4.tgz#2c89d6889b5eac522a7eea32c14521559c6cbf02"
   integrity sha1-LInWiJterFIqfuoywUUhVZxsvwI=
 
+js-cookie@^2.2.1:
+  version "2.2.1"
+  resolved "https://registry.yarnpkg.com/js-cookie/-/js-cookie-2.2.1.tgz#69e106dc5d5806894562902aa5baec3744e9b2b8"
+  integrity sha512-HvdH2LzI/EAZcUwA8+0nKNtWHqS+ZmijLA30RwZA0bo7ToCckjK5MkGhjED9KoRcXO6BaGI3I9UIzSA1FKFPOQ==
+
 js-sha256@^0.3.0:
   version "0.3.2"
   resolved "https://registry.yarnpkg.com/js-sha256/-/js-sha256-0.3.2.tgz#db09592455164191ce8171a4888cd957c67bf0ed"