Skip to content

Add marker message #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Add marker message #15

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1297e1
Add last message marker
liorbond Apr 3, 2023
20c9294
Update cosmos_msg.rs
Apr 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/std/src/results/cosmos_msg.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ pub enum CosmosMsg<T = Empty> {
Wasm(WasmMsg),
#[cfg(feature = "stargate")]
Gov(GovMsg),
LastMsgMark(T),
Copy link

@assafmo assafmo Apr 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make it prettier, i.e. so devs won't need to pass a boilerplate Empty {} as T?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already merged the changes to the main PR, so I'll change this in a separate one

Copy link

@assafmo assafmo Apr 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's alright, just asking out of curiosity. It's a matter of optimizing dev-x at this point.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think FinilizeTx is a better name here, as it's not just a "last message marker" within the tx, but also within that last message it's the last thing that will happen.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already merged the changes to the main PR, so I'll change this in a separate one

}

/// The message types of the bank module.
Expand Down