Add marker message #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assafmo
approved these changes
Apr 13, 2023
assafmo
reviewed
Apr 13, 2023
| Wasm(WasmMsg), | ||
| #[cfg(feature = "stargate")] | ||
| Gov(GovMsg), | ||
| LastMsgMark(T), |
There was a problem hiding this comment.
Can we make it prettier, i.e. so devs won't need to pass a boilerplate Empty {} as T?
There was a problem hiding this comment.
I already merged the changes to the main PR, so I'll change this in a separate one
There was a problem hiding this comment.
That's alright, just asking out of curiosity. It's a matter of optimizing dev-x at this point.
assafmo
reviewed
Apr 13, 2023
| Wasm(WasmMsg), | ||
| #[cfg(feature = "stargate")] | ||
| Gov(GovMsg), | ||
| LastMsgMark(T), |
There was a problem hiding this comment.
Also, I think FinilizeTx is a better name here, as it's not just a "last message marker" within the tx, but also within that last message it's the last thing that will happen.
There was a problem hiding this comment.
I already merged the changes to the main PR, so I'll change this in a separate one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.