Skip to content

Splitting PR #44: BaseFold Profile and Cycle Reduction #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 168 commits into from
Aug 7, 2025
Merged

Splitting PR #44: BaseFold Profile and Cycle Reduction #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
168 commits
Select commit Hold shift + click to select a range
fcb8ed5
Dense Matrix
Apr 22, 2025
66c7734
Added hints
Apr 22, 2025
6f8fe11
Finished get_base_codeword_dimensions
Apr 23, 2025
3813078
WIP mmcs
Apr 23, 2025
b10539b
WIP mmcs
Apr 24, 2025
8c35009
Update mmcs
Apr 25, 2025
3afc01b
WIP mmcs
Apr 26, 2025
1156331
Finished MMCS
Apr 28, 2025
18aef52
Added dot_product
Apr 29, 2025
31cd29c
query_phase input
Apr 29, 2025
85f00f2
WIP query_phase
Apr 29, 2025
ef34a42
Fix bug in sorting
Apr 30, 2025
b63abd8
WIP query phase
May 1, 2025
2a5f3da
WIP query phase
May 1, 2025
f4c21af
WIP query phase
May 1, 2025
746f04f
WIP query phase
May 2, 2025
6f98a17
New Sorting Impl
May 4, 2025
8e3312b
WIP query phase
May 5, 2025
dda2fff
WIP query phase
May 6, 2025
39443ef
WIP query phase
May 6, 2025
520da7e
Finished query_phase encoding
May 6, 2025
282892f
Support serialized input
May 10, 2025
0dc7b56
Implement the naive encode small method
yczhangsjtu May 15, 2025
c06f3c9
Bug workaround
May 16, 2025
7da7077
Merge branch 'kunming/basefold-verifier' into cyte/remove-early-stopping
yczhangsjtu May 16, 2025
4553fc3
Temp store: starting to use openvm mmcs instruction
yczhangsjtu May 30, 2025
39fa15c
Temp store: index to bits
yczhangsjtu May 30, 2025
2acf9eb
Temp store: clean up mmcs
yczhangsjtu May 30, 2025
4ffe361
Temp store: clear compilation errors
yczhangsjtu May 30, 2025
fbeda8b
Merge e2e modification
yczhangsjtu Jun 3, 2025
629bb23
Fix compilation error
yczhangsjtu Jun 3, 2025
8044af5
Merge remote-tracking branch 'origin/main' into cyte/switch-mmcs
yczhangsjtu Jun 3, 2025
2516cf5
Fix hash variable reading bug
yczhangsjtu Jun 3, 2025
ba93b0b
Use dyn array for dimensions
yczhangsjtu Jun 3, 2025
ec5e218
Fix multiplication between var and ext
yczhangsjtu Jun 3, 2025
586bc0d
Fix mmcs reading
yczhangsjtu Jun 6, 2025
b35aa5d
Remove unnecessary witness stream
yczhangsjtu Jun 10, 2025
0b8d751
Add doc for generating mmcs test data
yczhangsjtu Jun 10, 2025
ac1cbfd
Try fixing mmcs
yczhangsjtu Jun 11, 2025
4f22895
Try fixing mmcs
yczhangsjtu Jun 11, 2025
0b66801
Try fixing mmcs
yczhangsjtu Jun 11, 2025
25c21c0
Add comment
yczhangsjtu Jun 11, 2025
edc4848
Use the same poseidon2 constants as the test data
yczhangsjtu Jun 11, 2025
c04e4b7
Specify branch for test data gen
yczhangsjtu Jun 11, 2025
d5c8baa
MMCS test passes
yczhangsjtu Jun 11, 2025
8029daa
Rewrite fold coeff according to current basefold code
yczhangsjtu Jun 13, 2025
c1e92b0
Fix
yczhangsjtu Jun 19, 2025
188eb85
Merge branch 'main' of https://github.com/scroll-tech/ceno-recursion-…
yczhangsjtu Jun 19, 2025
fa3210c
Merge branches 'cyte/fix-query-phase' and 'main' of https://github.co…
yczhangsjtu Jun 23, 2025
e28b481
Merge e2e modification
yczhangsjtu Jun 23, 2025
dd6d6bd
Fix compilation errors from merge
yczhangsjtu Jun 23, 2025
6ba1fea
Fix compilation errors from merge
yczhangsjtu Jun 23, 2025
5c2b6b5
Fix compilation errors from merge
yczhangsjtu Jun 23, 2025
8cb2ad7
(WIP) Connecting e2e with query phase
yczhangsjtu Jun 23, 2025
cde8886
Merge remote-tracking branch 'origin/main' into cyte/fix-query-phase
kunxian-xia Jun 23, 2025
5361f3f
WIP
yczhangsjtu Jun 23, 2025
5f60470
Merge branch 'cyte/fix-query-phase' of https://github.com/scroll-tech…
yczhangsjtu Jun 23, 2025
37fb5f8
(WIP) transform ceno query phase verifier input to current
yczhangsjtu Jun 24, 2025
1feb92c
(WIP) Fix query phase transform
yczhangsjtu Jun 24, 2025
410e996
(WIP) Fix query phase transform
yczhangsjtu Jun 24, 2025
fbd5f1f
(WIP) Fix query phase transform
yczhangsjtu Jun 24, 2025
dd7951d
(WIP) Fix query phase transform
yczhangsjtu Jun 24, 2025
6f35d7b
Fix query phase transform
yczhangsjtu Jun 24, 2025
478ef69
Comment out connecting code temporarily
yczhangsjtu Jun 25, 2025
9689d1d
Query phase compile successful
yczhangsjtu Jun 25, 2025
94d4c13
(WIP) Debugging query phase
yczhangsjtu Jun 25, 2025
d0a45ca
Fix a bug in verifier query phase
yczhangsjtu Jun 26, 2025
8a61142
Read additional hints from binary file
yczhangsjtu Jun 26, 2025
f01ae48
Fix: batch opening (#28)
kunxian-xia Jul 8, 2025
6417088
Switch ceno reliance
yczhangsjtu Jul 11, 2025
4ac1628
Merge remote-tracking branch 'origin/main' into feat/simplify-basefol…
yczhangsjtu Jul 11, 2025
6069a53
Fix compilation errors due to out of date code
yczhangsjtu Jul 11, 2025
4e6d3e0
Update test query phase batch
yczhangsjtu Jul 14, 2025
07d2fba
Fix query opening proof
yczhangsjtu Jul 14, 2025
662396a
Implement basefold proof variable
yczhangsjtu Jul 15, 2025
e1c9ded
Update query phase verifier input
yczhangsjtu Jul 15, 2025
11fbced
Preparing test data for query phase with updated code
yczhangsjtu Jul 15, 2025
b6bdd1a
Implement basefold proof transform
yczhangsjtu Jul 15, 2025
a511a98
Prepare query phase verifier input
yczhangsjtu Jul 15, 2025
fc4e5ba
Prepare query phase verifier input
yczhangsjtu Jul 15, 2025
7ee316c
Fix final message access
yczhangsjtu Jul 16, 2025
0dc34f7
Switch ceno reliance to small field support
yczhangsjtu Jul 16, 2025
34f53ce
Create basefold verifier function
yczhangsjtu Jul 16, 2025
1dd84da
Check final message sizes
yczhangsjtu Jul 16, 2025
3744986
Fix final message size
yczhangsjtu Jul 16, 2025
ba814a5
Fix final message size
yczhangsjtu Jul 16, 2025
f130d21
Check query opening proof len
yczhangsjtu Jul 16, 2025
e883efb
Compute total number of polys
yczhangsjtu Jul 16, 2025
3629b44
Sample batch coeffs
yczhangsjtu Jul 16, 2025
12b81e3
Compute max_num_var
yczhangsjtu Jul 17, 2025
a68999b
Write sumcheck messages and commits to transcript
yczhangsjtu Jul 17, 2025
f9f244c
Write final message to transcript
yczhangsjtu Jul 17, 2025
89e5e7e
Complete the code for batch verifier
yczhangsjtu Jul 17, 2025
5ac05e7
Add verifier test
yczhangsjtu Jul 21, 2025
ac4cc44
Try to fix some compilation errors in e2e
yczhangsjtu Jul 21, 2025
33fba3d
Connecting pcs with e2e
yczhangsjtu Jul 21, 2025
21c4d41
Simplify BaseFold verifier (#34)
yczhangsjtu Jul 21, 2025
389e2b2
Merge remote-tracking branch 'origin/cyte/fix-query-phase' into feat/…
yczhangsjtu Jul 21, 2025
b6c3942
Fix some issues after merge
yczhangsjtu Jul 21, 2025
d5861f2
Make compilation pass temporarily
yczhangsjtu Jul 21, 2025
785bb58
Make test pass before query phase
yczhangsjtu Jul 21, 2025
71482b7
Merge remote-tracking branch 'origin/main' into cyte/fix-query-phase
kunxian-xia Jul 21, 2025
1c246a1
add multiple matrices as inputs to the basefold's unit test
kunxian-xia Jul 21, 2025
ba4ff69
fix
kunxian-xia Jul 21, 2025
c5f67c5
unit test passed
kunxian-xia Jul 21, 2025
24ba27e
support matrices that have same height
kunxian-xia Jul 21, 2025
f2faf8e
refactor tests
kunxian-xia Jul 21, 2025
d1269c2
Merge pull request #39 from scroll-tech/feat/basefold_multiple_mats
yczhangsjtu Jul 22, 2025
d3b6627
Merge remote
yczhangsjtu Jul 22, 2025
197ed35
Supply the permutation and make the random case pass
yczhangsjtu Jul 22, 2025
6824da4
Try fixing transcript inconsistency
yczhangsjtu Jul 22, 2025
db26b0f
Use bin to dec le
yczhangsjtu Jul 22, 2025
45a2c4c
Add pow witness
yczhangsjtu Jul 22, 2025
dcc4c5c
Basefold verifier passes for simple case
yczhangsjtu Jul 22, 2025
5aa023c
Update dependency
yczhangsjtu Jul 23, 2025
7e67692
Basefold verifier passes decreasing and random batches
yczhangsjtu Jul 23, 2025
88a78d7
update ceno dependencies
kunxian-xia Jul 23, 2025
eac11ed
comment out patch
kunxian-xia Jul 23, 2025
cd9f4d9
refactor
kunxian-xia Jul 23, 2025
32eacb6
the computation of max_num_var is simplified
kunxian-xia Jul 23, 2025
692f453
put perm to RoundVariable
kunxian-xia Jul 24, 2025
8e0911a
Change the way for computing batch
yczhangsjtu Jul 24, 2025
ec51a95
Remove the unnecessary slice
yczhangsjtu Jul 24, 2025
156f5e6
Simplify code
yczhangsjtu Jul 24, 2025
86476a1
Fix bug: the first mmcs batch verify passes
yczhangsjtu Jul 24, 2025
6f91a61
Initialize all zeros
yczhangsjtu Jul 24, 2025
ed96105
remove debug routines
kunxian-xia Jul 24, 2025
136c6b6
rename
kunxian-xia Jul 24, 2025
bc81fdb
clean
kunxian-xia Jul 24, 2025
a3c83e1
cleanup
kunxian-xia Jul 24, 2025
18fd5d3
ignore e2e test
kunxian-xia Jul 24, 2025
eba50fd
Complete Basefold verifier and Basefold e2e integration (#36)
yczhangsjtu Jul 24, 2025
75b0270
Merge remote
yczhangsjtu Jul 24, 2025
989eb3e
Fix
yczhangsjtu Jul 24, 2025
9d02328
Fix one bug: alpha is batch coeffs 1 not 0
yczhangsjtu Jul 24, 2025
946612f
Handle case when batch size is 1
yczhangsjtu Jul 24, 2025
d16990c
Allocate all zeros only once
yczhangsjtu Jul 25, 2025
64f47e7
Construct test multiple rounds and test with fibonacci e2e data
yczhangsjtu Jul 28, 2025
ad1b459
Add trace subscriber to profile cycles
yczhangsjtu Jul 28, 2025
2b8bf5b
Profile query phase
yczhangsjtu Jul 28, 2025
f988e21
Profile query phase
yczhangsjtu Jul 29, 2025
9dfcd39
Some small optimizations
yczhangsjtu Jul 30, 2025
0684e6b
Allocate opened values buffer outside query loop
yczhangsjtu Jul 30, 2025
444c3ab
Compute low high values buffer outside loop
yczhangsjtu Jul 30, 2025
ee50a8f
Compute alpha offset outside loop
yczhangsjtu Jul 30, 2025
b31940f
Remove batch coeffs offset
yczhangsjtu Jul 30, 2025
2963e88
Compute all zero slices outside loop
yczhangsjtu Jul 30, 2025
dfc2282
Remove round openings from loop
yczhangsjtu Jul 30, 2025
c841a51
Clean ups
yczhangsjtu Jul 30, 2025
147da66
Compute height outside loop
yczhangsjtu Jul 30, 2025
5b4d094
Compute permuted dimensions outside loop
yczhangsjtu Jul 30, 2025
22418cc
Merge two loops over openings
yczhangsjtu Jul 30, 2025
70705e1
Profile fri rounds
yczhangsjtu Jul 31, 2025
dbdd10f
Merge branch 'feat/basefold-verifier-e2e' into feat/basefold-optimize…
yczhangsjtu Jul 31, 2025
7a0b71e
Merge branch 'feat/basefold-optimize-batch' into feat/basefold-profil…
yczhangsjtu Jul 31, 2025
6186354
Merge remote-tracking branch 'origin/main' into feat/basefold-profile…
yczhangsjtu Jul 31, 2025
d6a423c
Fix compilation errors after merge
yczhangsjtu Jul 31, 2025
23f0eb5
Dependencies moved to dev
yczhangsjtu Jul 31, 2025
9a78fb5
Merge remote-tracking branch 'origin/main' into feat/basefold-profile…
kunxian-xia Aug 5, 2025
d8ffe0c
Merge remote-tracking branch 'origin/main' into feat/zkvm-profile-cyc…
yczhangsjtu Aug 6, 2025
6d15b0b
Fix unit tests
yczhangsjtu Aug 6, 2025
dc978b6
chore remove unused dependency
kunxian-xia Aug 6, 2025
c7146c1
Remove opening height from round context: duplicate of log2_height
yczhangsjtu Aug 7, 2025
490a0b4
Compute low and high values buffer in loop
yczhangsjtu Aug 7, 2025
91fed2c
Provide some comments
yczhangsjtu Aug 7, 2025
181c583
All zeros slice computed in loop
yczhangsjtu Aug 7, 2025
5e38460
Fix small issues
yczhangsjtu Aug 7, 2025
5c735f2
Merge remote-tracking branch 'origin/main' into feat/zkvm-profile-cyc…
kunxian-xia Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading