Skip to content

Splitting PR #44: BaseFold Profile and Cycle Reduction #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 168 commits into from
Aug 7, 2025
Merged

Splitting PR #44: BaseFold Profile and Cycle Reduction #54

merged 168 commits into from
Aug 7, 2025

Conversation

yczhangsjtu
Copy link
Collaborator

@yczhangsjtu yczhangsjtu commented Aug 6, 2025 •
edited by kunxian-xia
Loading

Summary

This is replicate of #41. This PR takes advantage of the FriReducedOpeningChip to reduce the cycles to compute

$$\sum_i \alpha^i * \textrm{opened\_values}_i $$

Performance

ceno guest program OpenVM cycles (before) OpenVM cycles (after)
fib(2^10) 2788892 1401910 (50%⬇️)
fib(2^20) 3286565 1899653 (42%⬇️)

Kunming Jiang and others added 30 commits April 22, 2025 11:35
Dense Matrix
fcb8ed5
Added hints
66c7734
Finished get_base_codeword_dimensions
6f8fe11
WIP mmcs
3813078
WIP mmcs
b10539b
Update mmcs
8c35009
WIP mmcs
3afc01b
Finished MMCS
1156331
Added dot_product
18aef52
query_phase input
31cd29c
WIP query_phase
85f00f2
Fix bug in sorting
ef34a42
WIP query phase
b63abd8
WIP query phase
2a5f3da
WIP query phase
f4c21af
WIP query phase
746f04f
New Sorting Impl
6f98a17
WIP query phase
8e3312b
WIP query phase
dda2fff
WIP query phase
39443ef
Finished query_phase encoding
520da7e
Support serialized input
282892f
@yczhangsjtu
Implement the naive encode small method
0dc7b56
Bug workaround
c06f3c9
@yczhangsjtu
Merge branch 'kunming/basefold-verifier' into cyte/remove-early-stopping
7da7077
@yczhangsjtu
Temp store: starting to use openvm mmcs instruction
4553fc3
@yczhangsjtu
Temp store: index to bits
39fa15c
@yczhangsjtu
Temp store: clean up mmcs
2acf9eb
@yczhangsjtu
Temp store: clear compilation errors
4ffe361
@yczhangsjtu
Merge e2e modification
fbeda8b
@yczhangsjtu yczhangsjtu mentioned this pull request Aug 6, 2025
Closed
@kunxian-xia kunxian-xia linked an issue Aug 6, 2025 that may be closed by this pull request
BaseFold verifier cycle reduction: FRI rounds part #47
Closed
kunxian-xia
kunxian-xia reviewed Aug 7, 2025
View reviewed changes
kunxian-xia
kunxian-xia reviewed Aug 7, 2025
View reviewed changes
@kunxian-xia kunxian-xia added the enhancement New feature or request label Aug 7, 2025
kunxian-xia
kunxian-xia reviewed Aug 7, 2025
View reviewed changes
kunxian-xia
kunxian-xia reviewed Aug 7, 2025
View reviewed changes
@kunxian-xia kunxian-xia removed a link to an issue Aug 7, 2025
BaseFold verifier cycle reduction: FRI rounds part #47
Closed
kunxian-xia
kunxian-xia approved these changes Aug 7, 2025
View reviewed changes
Copy link
Collaborator

@kunxian-xia kunxian-xia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@kunxian-xia kunxian-xia merged commit b0029f1 into main Aug 7, 2025
2 checks passed
@kunxian-xia kunxian-xia mentioned this pull request Aug 7, 2025
Closed
@kunxian-xia kunxian-xia deleted the feat/zkvm-profile-cycles-split-basefold branch August 7, 2025 12:41
@kunxian-xia kunxian-xia mentioned this pull request Aug 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunxian-xia kunxian-xia kunxian-xia approved these changes

Assignees

@yczhangsjtu yczhangsjtu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yczhangsjtu @kunxian-xia