This repository was archived by the owner on May 7, 2025. It is now read-only.
Update READMEs to Match go Versions and Update CentOS to 1.10.2 #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can one of the admins verify this patch? |
4 similar comments
Collaborator
|
Can one of the admins verify this patch? |
Collaborator
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
Contributor
Author
|
@pkubatrh Can you review this when you have a moment? |
|
@hhorak fyi |
Member
|
@jcajka, it looks ok to me, but I saw you commented in the issues mentioned above, so if there is a reason to not merge it, let me know. |
Contributor
Author
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the image stream for CentOS lists its go version as 1.8. However, the image associated with the stream is version 1.10.2. This pull request clarifies that the image stream uses 1.10.
This pull request also reformats the image streams to match the format of other image streams under
sclorg. Additionally, READMEs in descriptions have been updated to match the appropriate READMEs associated with particular versions.In the long term, each version should be tagged appropriately as described in #20 and #24, but this will be a temporary solution for explicitly saying what versions of go are supported currently.