Skip to content

Conversation

@danielhelfand
Copy link

@danielhelfand danielhelfand commented Jun 29, 2019

The image used for the golang imagestream is actually golang 1.10.2, not golang 1.8. The image under the go-toolset-7-centos7 Dockerhub is only tagged with latest and that image is supporting 1.10.2.

This can be verified by pulling the image and checking its golang version:

$ docker run -it docker.io/centos/go-toolset-7-centos7:latest bash
bash-4.2$ go version
go version go1.10.2 linux/amd64

This was originally opened as a pr to sclorg/golang-container, but I'm not sure who if anyone is maintaining that repo anymore. So I thought it made sense to try opening this here.

@openshift-ci-robot
Copy link

Hi @danielhelfand. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: danielhelfand
To complete the pull request process, please assign adambkaplan
You can assign the PR to them by writing /assign @adambkaplan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 29, 2019
@adambkaplan
Copy link
Contributor

/close

openshift/library automatically syncs its content from upstream imagestream repos. Existing PR there should be sufficient.

@openshift-ci-robot
Copy link

@adambkaplan: Closed this PR.

In response to this:

/close

openshift/library automatically syncs its content from upstream imagestream repos. Existing PR there should be sufficient.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danielhelfand
Copy link
Author

@adambkaplan Thanks! Wasn't sure whose attention to get over in sclorg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants