Skip to content

Test failures and compiler warnings #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 23, 2024
Merged

Test failures and compiler warnings #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dc23108
Use resize() instead of reserve() to allocate vector elements
ellert Jun 19, 2023
e165d0b
Print err_msg in case of error
ellert Jun 19, 2023
8302815
Move key cache tests to the end to avoid random failures in other
ellert Jun 19, 2023
f7a2e11
Fix some compiler warnings
ellert Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/scitokens_internal.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,7 +630,7 @@ Validator::get_public_keys_from_web(const std::string &issuer,
auto cget_status = status->m_cget->perform_start(openid_metadata);
status->m_continue_fetch = true;
if (!cget_status.m_done) {
return std::move(status);
return status;
}
return get_public_keys_from_web_continue(std::move(status));
}
Expand Down Expand Up @@ -744,7 +744,6 @@ std::string Validator::get_jwks(const std::string &issuer) {
}

bool Validator::refresh_jwks(const std::string &issuer) {
int64_t next_update, expires;
picojson::value keys;
std::unique_ptr<scitokens::AsyncStatus> status = get_public_keys_from_web(
issuer, internal::SimpleCurlGet::extended_timeout);
Expand Down Expand Up @@ -978,9 +977,9 @@ bool scitokens::Validator::store_public_ec_key(const std::string &issuer,
auto x_num = BN_num_bytes(x_bignum.get());
auto y_num = BN_num_bytes(y_bignum.get());
std::vector<unsigned char> x_bin;
x_bin.reserve(x_num);
x_bin.resize(x_num);
std::vector<unsigned char> y_bin;
y_bin.reserve(y_num);
y_bin.resize(y_num);
BN_bn2bin(x_bignum.get(), &x_bin[0]);
BN_bn2bin(y_bignum.get(), &y_bin[0]);
std::string x_str(reinterpret_cast<char *>(&x_bin[0]), x_num);
Expand Down
2 changes: 1 addition & 1 deletion src/scitokens_internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,7 +670,7 @@ class Validator {
}
std::unique_ptr<AsyncStatus> result(new AsyncStatus());
result->m_done = true;
return std::move(result);
return result;
}

void add_critical_claims(const std::vector<std::string> &claims) {
Expand Down
Loading