Test failures and compiler warnings #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ RUN ] SerializeTest.VerifyTest /usr/include/c++/13/bits/stl_vector.h:1125: std::vector<_Tp, _Alloc>::reference std::vector<_Tp, _Alloc>::operator[](size_type) [with _Tp = unsigned char; _Alloc = std::allocator<unsigned char>; reference = unsigned char&; size_type = long unsigned int]: Assertion '__n < this->size()' failed.
tests due to interference from changing the cache expiration settings in the key cache tests.
.../src/scitokens_internal.h:673:25: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move]
673 | return std::move(result);
| ~~~~~~~~~^~~~~~~~
.../src/scitokens_internal.h:673:25: note: remove 'std::move' call
.../src/scitokens_internal.cpp:633:25: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move]
633 | return std::move(status);
| ~~~~~~~~~^~~~~~~~
.../src/scitokens_internal.cpp:633:25: note: remove 'std::move' call
.../src/scitokens_internal.cpp:747:13: warning: unused variable 'next_update' [-Wunused-variable]
747 | int64_t next_update, expires;
| ^~~~~~~~~~~
.../src/scitokens_internal.cpp:747:26: warning: unused variable 'expires' [-Wunused-variable]
747 | int64_t next_update, expires;
| ^~~~~~~
.../test/main.cpp:442:12: warning: unused variable 'now' [-Wunused-variable]
442 | time_t now = time(NULL);
| ^~~
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Many thanks, @ellert ! To weigh in on this, the It would be nice to see these fixes merged in the next release so distro patches can be dropped again. |
djw8605
approved these changes
Jan 23, 2024
|
@djw8605 Many thanks, much appreciated 👍 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move key cache tests to the end to avoid random failures in other tests due to interference from changing the cache expiration settings in the key cache tests.
Print err_msg in case of error
Use resize() instead of reserve() to allocate vector elements