Skip to content

Conversation

henryiii
Copy link
Collaborator

Pulling out the API change from #637.

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 86.23%. Comparing base (276bb17) to head (f5c8072).

Files Patch % Lines
...cikit_build_core/settings/skbuild_read_settings.py 80.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #697      +/-   ##
==========================================
- Coverage   86.30%   86.23%   -0.07%     
==========================================
  Files          64       64              
  Lines        3315     3321       +6     
==========================================
+ Hits         2861     2864       +3     
- Misses        454      457       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henryiii henryiii merged commit dcb36dd into main Apr 11, 2024
@henryiii henryiii deleted the henryiii/feat/extra_settings branch April 11, 2024 22:09
@henryiii henryiii mentioned this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant