Skip to content

feat: experimental hatchling builder #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Apr 17, 2024
Merged

feat: experimental hatchling builder #637

merged 24 commits into from
Apr 17, 2024

Conversation

henryiii
Copy link
Collaborator

In progress.

@henryiii henryiii force-pushed the henryiii/feat/hatchplugin branch from 44078ba to dc32917 Compare February 13, 2024 23:04
@codecov Codecov
Copy link

codecov bot commented Feb 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 27.32240% with 133 lines in your changes are missing coverage. Please review.

Project coverage is 83.13%. Comparing base (09e999d) to head (87fe60d).
Report is 2 commits behind head on main.

Files Patch % Lines
src/scikit_build_core/hatch/plugin.py 21.42% 132 Missing ⚠️
src/scikit_build_core/hatch/hooks.py 90.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #637      +/-   ##
==========================================
- Coverage   86.22%   83.13%   -3.09%     
==========================================
  Files          64       67       +3     
  Lines        3331     3511     +180     
==========================================
+ Hits         2872     2919      +47     
- Misses        459      592     +133

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henryiii henryiii force-pushed the henryiii/feat/hatchplugin branch 3 times, most recently from a91c7d7 to 38384d4 Compare February 14, 2024 04:17
@henryiii
Copy link
Collaborator Author

@aryamanjeendgar, it's passing now, so ready for you to work on it.

@henryiii henryiii mentioned this pull request Mar 19, 2024
Closed
@henryiii henryiii mentioned this pull request Mar 30, 2024
Closed
@ofek ofek mentioned this pull request Apr 9, 2024
Merged
@henryiii henryiii force-pushed the henryiii/feat/hatchplugin branch from 0395f84 to 7bf2f98 Compare April 11, 2024 21:07
@henryiii henryiii mentioned this pull request Apr 11, 2024
Merged
ofek
ofek reviewed Apr 11, 2024
View reviewed changes
tests/constraints.txt
@@ -1,12 +1,13 @@
cattrs==22.2.0
hatchling==0.25.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this to support Python 2? If so, note that there is a patch release after this one.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, 3.7 is our oldest. Was just trying to pick the oldest one easy to support as a minimum. Can change if you'd like.

@henryiii
Copy link
Collaborator Author

I've pulled the API change out so we can ship that for third party plugins sooner. #697

henryiii added a commit that referenced this pull request Apr 11, 2024
@henryiii
feat(api): extra_settings for SettingsReader (#697)
dcb36dd 
Pulling out the API change from #637.

Signed-off-by: Henry Schreiner <[email protected]>
@ofek
Copy link
Contributor

ofek commented Apr 11, 2024

I know you're not finished but don't forget that I implemented the dynamic dependencies feature you requested!

@henryiii henryiii mentioned this pull request Apr 12, 2024
Merged
henryiii added a commit that referenced this pull request Apr 12, 2024
@henryiii
refactor: GetRequires args changed (#699)
503c88d 
This is needed for
#637 (comment).

Signed-off-by: Henry Schreiner <[email protected]>
@henryiii henryiii mentioned this pull request Apr 12, 2024
Merged
henryiii added a commit that referenced this pull request Apr 12, 2024
@henryiii
refactor: make from_file a little more powerful (#700)
c8f7542 
A little bit of optimization for plugin use, such as #637.

Signed-off-by: Henry Schreiner <[email protected]>
@henryiii henryiii force-pushed the henryiii/feat/hatchplugin branch 2 times, most recently from ced63df to 3a15845 Compare April 13, 2024 03:09
@henryiii
Copy link
Collaborator Author

TODO: self.directory is ./dist, not a temp build directory. We'll have to make one ourselves, and clean it in finalize & if there's an error.

@henryiii henryiii force-pushed the henryiii/feat/hatchplugin branch from 3a15845 to 91a766f Compare April 15, 2024 05:25
henryiii added 4 commits April 15, 2024 01:32
@henryiii
tests: fix package requirements
478b81c 
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii
chore: ignore pylint duplicate code for plugin
60bb748 
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii
docs: missing link
e9288bf 
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii
fix: use latest hatchling
64b3ef7 
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii henryiii changed the title WIP: setting up hatchling builder feat: experimental hatchling builder Apr 16, 2024
henryiii added 4 commits April 16, 2024 02:25
@henryiii
tests: skip module not found error for import all check
5638bae 
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii
tests: handle ext_suffix
f2eb9dc 
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii
fix: glob wheel
7dde1cb 
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii
tests: skip pypy 3.7 & uv
0cc6dd2 
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii henryiii marked this pull request as ready for review April 16, 2024 07:41
henryiii
henryiii commented Apr 16, 2024
View reviewed changes
@henryiii henryiii merged commit 7002c58 into main Apr 17, 2024
@henryiii henryiii deleted the henryiii/feat/hatchplugin branch April 17, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ofek ofek ofek left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henryiii @ofek @aryamanjeendgar