Support python (jython) rename syntax highlighting #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this language was named Python, syntax highlighting was supported directly using the default python highlighter available in rsyntaxtextarea. The name change to Python (Jython) disrupts this support. To add back syntax highlighting support for the new name, this PR adds two dependencies:
Also this bumps the pom to version 32.0.0-beta-4 (not required, but I did it). the new class JythonScriptSyntaxHighlighter is added that adds the language name python-(jython) for syntax highlighting using the PythonTokenMaker.
I guess the added dependencies are not ideal, especially the rsyntaxtextarea. I guess there could be other hacky solutions like the current implementation that changes the names so the default highlighters work...
Changes to autocompletion were also required as a result of this name change. They can be found in this PR scijava/script-editor-jython#17.
What should be do?